Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Publish snapshots to maven via GHA workflow #690

Merged
merged 4 commits into from
Feb 21, 2023

Conversation

Angie-Zhang
Copy link
Contributor

Issue #, if available:
#689

Description of changes:
Added Publish snapshots to maven via GHA workflow

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Angie-Zhang Angie-Zhang requested review from a team and gaiksaya February 18, 2023 02:20
Signed-off-by: Angie Zhang <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Merging #690 (d9808e1) into main (e35ed1f) will decrease coverage by 0.06%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #690      +/-   ##
============================================
- Coverage     75.88%   75.82%   -0.06%     
+ Complexity     2655     2647       -8     
============================================
  Files           333      333              
  Lines         15400    15400              
  Branches       2272     2272              
============================================
- Hits          11686    11677       -9     
- Misses         2392     2401       +9     
  Partials       1322     1322              
Impacted Files Coverage Δ
...statemanagement/validation/ValidateReplicaCount.kt 0.00% <0.00%> (-32.15%) ⬇️
...ndexstatemanagement/validation/ActionValidation.kt 86.66% <0.00%> (-13.34%) ⬇️
...ndexstatemanagement/validation/ValidateRollover.kt 66.66% <0.00%> (-9.53%) ⬇️
.../indexstatemanagement/validation/ValidateDelete.kt 47.05% <0.00%> (-5.89%) ⬇️
.../action/explain/TransportExplainTransformAction.kt 70.78% <0.00%> (-2.25%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 70.23% <0.00%> (ø)
...earch/indexmanagement/transform/model/Transform.kt 86.01% <0.00%> (+0.42%) ⬆️
...agement/indexstatemanagement/ManagedIndexRunner.kt 47.57% <0.00%> (+0.44%) ⬆️
...exmanagement/opensearchapi/OpenSearchExtensions.kt 76.92% <0.00%> (+0.85%) ⬆️
...nt/rollup/action/stop/TransportStopRollupAction.kt 77.64% <0.00%> (+1.17%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

build.gradle Outdated Show resolved Hide resolved
Signed-off-by: Angie Zhang <[email protected]>
@Angie-Zhang
Copy link
Contributor Author

WhiteSource Security Check fails due to Vulnerable Library: snakeyaml-1.33.jar. This comes from OSCore.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the PUBLISH_SNAPSHOTS_ROLE secret.

@gaiksaya
Copy link
Member

Hi @Angie-Zhang ,
Just to confirm can you post the snapshots output from testing here? We observed a few glitches in other plugins.
Thanks!

@Angie-Zhang Angie-Zhang merged commit 9cdcffd into opensearch-project:main Feb 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2023
* Added Publish snapshots to maven via GHA workflow

Signed-off-by: Angie Zhang <[email protected]>

* Added Publish snapshots to maven via GHA workflow

Signed-off-by: Angie Zhang <[email protected]>

* Fixed CVE-2022-1471

Signed-off-by: Angie Zhang <[email protected]>

* Fixed review comments

Signed-off-by: Angie Zhang <[email protected]>

---------

Signed-off-by: Angie Zhang <[email protected]>
(cherry picked from commit 9cdcffd)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.6 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.6 2.6
# Navigate to the new working tree
cd .worktrees/backport-2.6
# Create a new branch
git switch --create backport/backport-690-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9cdcffd8c98a2f01530655fed451cef6b9e3ae66
# Push it to GitHub
git push --set-upstream origin backport/backport-690-to-2.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.6

Then, create a pull request where the base branch is 2.6 and the compare/head branch is backport/backport-690-to-2.6.

AWSHurneyt pushed a commit that referenced this pull request Feb 21, 2023
* Added Publish snapshots to maven via GHA workflow

Signed-off-by: Angie Zhang <[email protected]>

* Added Publish snapshots to maven via GHA workflow

Signed-off-by: Angie Zhang <[email protected]>

* Fixed CVE-2022-1471

Signed-off-by: Angie Zhang <[email protected]>

* Fixed review comments

Signed-off-by: Angie Zhang <[email protected]>

---------

Signed-off-by: Angie Zhang <[email protected]>
(cherry picked from commit 9cdcffd)

Co-authored-by: Angie Zhang <[email protected]>
@Angie-Zhang
Copy link
Contributor Author

Angie-Zhang commented Feb 21, 2023

Hi @Angie-Zhang , Just to confirm can you post the snapshots output from testing here? We observed a few glitches in other plugins. Thanks!

@gaiksaya I replied the results in the issue itself: #689 (comment)

wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
…#690) (opensearch-project#692)

* Added Publish snapshots to maven via GHA workflow

Signed-off-by: Angie Zhang <[email protected]>

* Added Publish snapshots to maven via GHA workflow

Signed-off-by: Angie Zhang <[email protected]>

* Fixed CVE-2022-1471

Signed-off-by: Angie Zhang <[email protected]>

* Fixed review comments

Signed-off-by: Angie Zhang <[email protected]>

---------

Signed-off-by: Angie Zhang <[email protected]>
(cherry picked from commit 9cdcffd)

Co-authored-by: Angie Zhang <[email protected]>
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
…#690) (opensearch-project#692)

* Added Publish snapshots to maven via GHA workflow

Signed-off-by: Angie Zhang <[email protected]>

* Added Publish snapshots to maven via GHA workflow

Signed-off-by: Angie Zhang <[email protected]>

* Fixed CVE-2022-1471

Signed-off-by: Angie Zhang <[email protected]>

* Fixed review comments

Signed-off-by: Angie Zhang <[email protected]>

---------

Signed-off-by: Angie Zhang <[email protected]>
(cherry picked from commit 9cdcffd)

Co-authored-by: Angie Zhang <[email protected]>
Signed-off-by: Ronnak Saxena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants