-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Publish snapshots to maven via GHA workflow #690
Conversation
Signed-off-by: Angie Zhang <[email protected]>
Signed-off-by: Angie Zhang <[email protected]>
Signed-off-by: Angie Zhang <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #690 +/- ##
============================================
- Coverage 75.88% 75.82% -0.06%
+ Complexity 2655 2647 -8
============================================
Files 333 333
Lines 15400 15400
Branches 2272 2272
============================================
- Hits 11686 11677 -9
- Misses 2392 2401 +9
Partials 1322 1322
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Angie Zhang <[email protected]>
WhiteSource Security Check fails due to Vulnerable Library: snakeyaml-1.33.jar. This comes from OSCore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the PUBLISH_SNAPSHOTS_ROLE
secret.
Hi @Angie-Zhang , |
* Added Publish snapshots to maven via GHA workflow Signed-off-by: Angie Zhang <[email protected]> * Added Publish snapshots to maven via GHA workflow Signed-off-by: Angie Zhang <[email protected]> * Fixed CVE-2022-1471 Signed-off-by: Angie Zhang <[email protected]> * Fixed review comments Signed-off-by: Angie Zhang <[email protected]> --------- Signed-off-by: Angie Zhang <[email protected]> (cherry picked from commit 9cdcffd)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.6 2.6
# Navigate to the new working tree
cd .worktrees/backport-2.6
# Create a new branch
git switch --create backport/backport-690-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9cdcffd8c98a2f01530655fed451cef6b9e3ae66
# Push it to GitHub
git push --set-upstream origin backport/backport-690-to-2.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.6 Then, create a pull request where the |
* Added Publish snapshots to maven via GHA workflow Signed-off-by: Angie Zhang <[email protected]> * Added Publish snapshots to maven via GHA workflow Signed-off-by: Angie Zhang <[email protected]> * Fixed CVE-2022-1471 Signed-off-by: Angie Zhang <[email protected]> * Fixed review comments Signed-off-by: Angie Zhang <[email protected]> --------- Signed-off-by: Angie Zhang <[email protected]> (cherry picked from commit 9cdcffd) Co-authored-by: Angie Zhang <[email protected]>
@gaiksaya I replied the results in the issue itself: #689 (comment) |
…#690) (opensearch-project#692) * Added Publish snapshots to maven via GHA workflow Signed-off-by: Angie Zhang <[email protected]> * Added Publish snapshots to maven via GHA workflow Signed-off-by: Angie Zhang <[email protected]> * Fixed CVE-2022-1471 Signed-off-by: Angie Zhang <[email protected]> * Fixed review comments Signed-off-by: Angie Zhang <[email protected]> --------- Signed-off-by: Angie Zhang <[email protected]> (cherry picked from commit 9cdcffd) Co-authored-by: Angie Zhang <[email protected]>
…#690) (opensearch-project#692) * Added Publish snapshots to maven via GHA workflow Signed-off-by: Angie Zhang <[email protected]> * Added Publish snapshots to maven via GHA workflow Signed-off-by: Angie Zhang <[email protected]> * Fixed CVE-2022-1471 Signed-off-by: Angie Zhang <[email protected]> * Fixed review comments Signed-off-by: Angie Zhang <[email protected]> --------- Signed-off-by: Angie Zhang <[email protected]> (cherry picked from commit 9cdcffd) Co-authored-by: Angie Zhang <[email protected]> Signed-off-by: Ronnak Saxena <[email protected]>
Issue #, if available:
#689
Description of changes:
Added Publish snapshots to maven via GHA workflow
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.