Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code difference #670

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Jan 25, 2023

Signed-off-by: bowenlan-amzn [email protected]

Issue #, if available:

Description of changes:

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Merging #670 (c6f769f) into main (76d530f) will decrease coverage by 0.17%.
The diff coverage is 25.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #670      +/-   ##
============================================
- Coverage     75.56%   75.39%   -0.17%     
+ Complexity     2657     2633      -24     
============================================
  Files           333      333              
  Lines         15395    15398       +3     
  Branches       2384     2386       +2     
============================================
- Hits          11633    11610      -23     
- Misses         2410     2424      +14     
- Partials       1352     1364      +12     
Impacted Files Coverage Δ
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 69.36% <25.00%> (-0.90%) ⬇️
...nagement/step/forcemerge/AttemptSetReadOnlyStep.kt 51.16% <0.00%> (-25.59%) ⬇️
...nt/indexstatemanagement/model/destination/Chime.kt 55.55% <0.00%> (-22.23%) ⬇️
...dexmanagement/transform/model/TransformMetadata.kt 83.49% <0.00%> (-8.74%) ⬇️
...gement/transform/model/ContinuousTransformStats.kt 66.66% <0.00%> (-7.41%) ⬇️
...arch/indexmanagement/rollup/RollupSearchService.kt 61.11% <0.00%> (-3.71%) ⬇️
...gement/indexstatemanagement/action/ShrinkAction.kt 69.11% <0.00%> (-2.95%) ⬇️
.../action/explain/TransportExplainTransformAction.kt 70.78% <0.00%> (-2.25%) ⬇️
...management/indexstatemanagement/MetadataService.kt 62.68% <0.00%> (-2.24%) ⬇️
...rch/indexmanagement/rollup/model/RollupMetadata.kt 84.39% <0.00%> (-1.74%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review January 26, 2023 01:03
@bowenlan-amzn bowenlan-amzn requested a review from a team January 26, 2023 01:03
Signed-off-by: bowenlan-amzn <[email protected]>
@bowenlan-amzn
Copy link
Member Author

Test failures are known flaky
#90 (comment)
#90 (comment)

@bowenlan-amzn bowenlan-amzn merged commit 536eb70 into opensearch-project:main Jan 30, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-670-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 536eb70708d3f3cf046ed8f43c39aaed58f19dd1
# Push it to GitHub
git push --set-upstream origin backport/backport-670-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-670-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 30, 2023
Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 536eb70)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 30, 2023
Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 536eb70)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-670-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 536eb70708d3f3cf046ed8f43c39aaed58f19dd1
# Push it to GitHub
git push --set-upstream origin backport/backport-670-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport/backport-670-to-2.5.

bowenlan-amzn added a commit to bowenlan-amzn/index-management that referenced this pull request Jan 30, 2023
bowenlan-amzn added a commit to bowenlan-amzn/index-management that referenced this pull request Jan 30, 2023
bowenlan-amzn added a commit that referenced this pull request Jan 30, 2023
Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 536eb70)

Co-authored-by: bowenlan-amzn <[email protected]>
bowenlan-amzn added a commit that referenced this pull request Jan 30, 2023
Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 536eb70)

Co-authored-by: bowenlan-amzn <[email protected]>
bowenlan-amzn added a commit that referenced this pull request Jan 31, 2023
bowenlan-amzn added a commit that referenced this pull request Jan 31, 2023
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants