-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce code difference #670
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #670 +/- ##
============================================
- Coverage 75.56% 75.39% -0.17%
+ Complexity 2657 2633 -24
============================================
Files 333 333
Lines 15395 15398 +3
Branches 2384 2386 +2
============================================
- Hits 11633 11610 -23
- Misses 2410 2424 +14
- Partials 1352 1364 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: bowenlan-amzn <[email protected]>
Test failures are known flaky |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-670-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 536eb70708d3f3cf046ed8f43c39aaed58f19dd1
# Push it to GitHub
git push --set-upstream origin backport/backport-670-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit 536eb70)
Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit 536eb70)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-670-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 536eb70708d3f3cf046ed8f43c39aaed58f19dd1
# Push it to GitHub
git push --set-upstream origin backport/backport-670-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5 Then, create a pull request where the |
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit 536eb70) Co-authored-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit 536eb70) Co-authored-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: Ronnak Saxena <[email protected]>
Signed-off-by: bowenlan-amzn [email protected]
Issue #, if available:
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.