Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for QueryStringQuery in rollups #616

Merged
merged 4 commits into from
Jan 10, 2023

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Nov 23, 2022

Signed-off-by: Petar Dzepina [email protected]

Issue #, if available:

#320

Description of changes:

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz petardz requested a review from a team November 23, 2022 00:22
@deshsidd
Copy link
Contributor

deshsidd commented Nov 23, 2022

FYI @nknize @rishabhmaurya @sbcd90 please review. Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2022

Codecov Report

Merging #616 (5cbae4a) into main (a21e4a6) will increase coverage by 0.40%.
The diff coverage is 75.18%.

❗ Current head 5cbae4a differs from pull request most recent head 05a559f. Consider uploading reports for the commit 05a559f to get more accurate results

@@             Coverage Diff              @@
##               main     #616      +/-   ##
============================================
+ Coverage     75.32%   75.73%   +0.40%     
- Complexity     2605     2656      +51     
============================================
  Files           330      333       +3     
  Lines         15111    15358     +247     
  Branches       2337     2380      +43     
============================================
+ Hits          11382    11631     +249     
+ Misses         2397     2369      -28     
- Partials       1332     1358      +26     
Impacted Files Coverage Δ
...transport/action/explain/TransportExplainAction.kt 70.75% <0.00%> (ø)
.../rollup/action/index/TransportIndexRollupAction.kt 72.09% <0.00%> (ø)
...nagement/rollup/query/QueryStringQueryParserExt.kt 46.15% <46.15%> (ø)
...agement/indexstatemanagement/ManagedIndexRunner.kt 47.13% <60.00%> (+1.35%) ⬆️
...management/rollup/interceptor/RollupInterceptor.kt 79.85% <65.00%> (-0.31%) ⬇️
...dexmanagement/rollup/query/QueryStringQueryUtil.kt 77.04% <77.04%> (ø)
...management/rollup/util/QueryShardContextFactory.kt 79.72% <79.72%> (ø)
...pensearch/indexmanagement/IndexManagementPlugin.kt 90.07% <100.00%> (+0.25%) ⬆️
...nsearch/indexmanagement/rollup/util/RollupUtils.kt 81.37% <100.00%> (+0.46%) ⬆️
...ensearch/indexmanagement/util/JobSchedulerUtils.kt 73.91% <100.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@praveensameneni
Copy link
Member

Reference: #320

@petardz petardz force-pushed the rollup-qsq-support branch 2 times, most recently from 82a1490 to 4c7b9ab Compare January 9, 2023 12:40
@petardz petardz force-pushed the rollup-qsq-support branch from 1c219ba to dcc6766 Compare January 9, 2023 13:49
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
@deshsidd deshsidd requested a review from sbcd90 January 9, 2023 23:39
@deshsidd deshsidd merged commit 3de566e into opensearch-project:main Jan 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* added support for QueryStringQuery in rollups

Signed-off-by: Petar Dzepina <[email protected]>

* detekt fix

Signed-off-by: Petar Dzepina <[email protected]>

* compile fix

Signed-off-by: Petar Dzepina <[email protected]>

* IT fix

Signed-off-by: Petar Dzepina <[email protected]>

Signed-off-by: Petar Dzepina <[email protected]>
(cherry picked from commit 3de566e)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* added support for QueryStringQuery in rollups

Signed-off-by: Petar Dzepina <[email protected]>

* detekt fix

Signed-off-by: Petar Dzepina <[email protected]>

* compile fix

Signed-off-by: Petar Dzepina <[email protected]>

* IT fix

Signed-off-by: Petar Dzepina <[email protected]>

Signed-off-by: Petar Dzepina <[email protected]>
(cherry picked from commit 3de566e)
bowenlan-amzn pushed a commit that referenced this pull request Jan 10, 2023
* added support for QueryStringQuery in rollups

Signed-off-by: Petar Dzepina <[email protected]>

* detekt fix

Signed-off-by: Petar Dzepina <[email protected]>

* compile fix

Signed-off-by: Petar Dzepina <[email protected]>

* IT fix

Signed-off-by: Petar Dzepina <[email protected]>

Signed-off-by: Petar Dzepina <[email protected]>
(cherry picked from commit 3de566e)

Co-authored-by: Petar Dzepina <[email protected]>
bowenlan-amzn pushed a commit that referenced this pull request Jan 10, 2023
* added support for QueryStringQuery in rollups

Signed-off-by: Petar Dzepina <[email protected]>

* detekt fix

Signed-off-by: Petar Dzepina <[email protected]>

* compile fix

Signed-off-by: Petar Dzepina <[email protected]>

* IT fix

Signed-off-by: Petar Dzepina <[email protected]>

Signed-off-by: Petar Dzepina <[email protected]>
(cherry picked from commit 3de566e)

Co-authored-by: Petar Dzepina <[email protected]>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
opensearch-project#654)

* added support for QueryStringQuery in rollups

Signed-off-by: Petar Dzepina <[email protected]>

* detekt fix

Signed-off-by: Petar Dzepina <[email protected]>

* compile fix

Signed-off-by: Petar Dzepina <[email protected]>

* IT fix

Signed-off-by: Petar Dzepina <[email protected]>

Signed-off-by: Petar Dzepina <[email protected]>
(cherry picked from commit 3de566e)

Co-authored-by: Petar Dzepina <[email protected]>
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
opensearch-project#654)

* added support for QueryStringQuery in rollups

Signed-off-by: Petar Dzepina <[email protected]>

* detekt fix

Signed-off-by: Petar Dzepina <[email protected]>

* compile fix

Signed-off-by: Petar Dzepina <[email protected]>

* IT fix

Signed-off-by: Petar Dzepina <[email protected]>

Signed-off-by: Petar Dzepina <[email protected]>
(cherry picked from commit 3de566e)

Co-authored-by: Petar Dzepina <[email protected]>
Signed-off-by: Ronnak Saxena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants