Fix all the compile warnings and detekt issues

[bowenlan-amzn]

Signed-off-by: bowenlan-amzn [email protected]

Issue #, if available:
#90
#239

Description of changes:
Fix all the compile warning and detekt warning. After this merged in, IM doesn't allow any change with compile warning or detekt warning to be merged in.

For the roles field deprecated in Rollup and Transform model, the usage in stream input and output is also deprecated. Specifically, stream output always write roles field as empty list.

CheckList:

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #603 (0869675) into main (efe2d33) will decrease coverage by 0.77%.
The diff coverage is 58.60%.

@@             Coverage Diff              @@
##               main     #603      +/-   ##
============================================
- Coverage     75.86%   75.09%   -0.78%     
- Complexity     2485     2589     +104     
============================================
  Files           316      330      +14     
  Lines         14546    15111     +565     
  Branches       2248     2337      +89     
============================================
+ Hits          11036    11348     +312     
- Misses         2253     2432     +179     
- Partials       1257     1331      +74     

Impacted Files	Coverage Δ
...ement/model/coordinator/SweptManagedIndexConfig.kt	78.12% <0.00%> (ø)
...nagement/step/rollup/AttemptCreateRollupJobStep.kt	49.18% <0.00%> (+0.79%)	⬆️
...action/changepolicy/TransportChangePolicyAction.kt	63.13% <ø> (ø)
...ent/indexstatemanagement/util/ManagedIndexUtils.kt	75.77% <0.00%> (-0.34%)	⬇️
...ment/indexstatemanagement/util/RestHandlerUtils.kt	88.88% <ø> (ø)
...statemanagement/validation/ValidateReplicaCount.kt	0.00% <0.00%> (ø)
.../rollup/action/index/TransportIndexRollupAction.kt	72.09% <ø> (+0.82%)	⬆️
...rch/indexmanagement/rollup/model/metric/Average.kt	83.33% <ø> (ø)
...nsearch/indexmanagement/rollup/model/metric/Max.kt	75.00% <ø> (ø)
...nsearch/indexmanagement/rollup/model/metric/Min.kt	75.00% <ø> (ø)
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[khushbr]

Thank you for fixing these deteckt issues @bowenlan-amzn. Helps improve the overall development sanity for the Repo.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-603-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a21e4a60b4f76c18c9f5eb2d2db9649750c92781
# Push it to GitHub
git push --set-upstream origin backport/backport-603-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-603-to-2.x.

[opensearch-trigger-bot]

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-603-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a21e4a60b4f76c18c9f5eb2d2db9649750c92781
# Push it to GitHub
git push --set-upstream origin backport/backport-603-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport/backport-603-to-2.4.