Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kotlin warnings #551

Merged

Conversation

deshsidd
Copy link
Contributor

@deshsidd deshsidd commented Oct 5, 2022

Signed-off-by: Siddhant Deshmukh [email protected]

Issue #239 , if available:

Description of changes:

  • Minor refactoring to reduce the warning messages in compileKotin

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Siddhant Deshmukh <[email protected]>
@deshsidd deshsidd requested a review from a team October 5, 2022 20:24
Signed-off-by: Siddhant Deshmukh <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #551 (956d5ac) into main (5217af0) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##               main     #551      +/-   ##
============================================
- Coverage     75.94%   75.94%   -0.01%     
- Complexity     2486     2489       +3     
============================================
  Files           316      316              
  Lines         14547    14546       -1     
  Branches       2248     2248              
============================================
- Hits          11048    11047       -1     
- Misses         2240     2241       +1     
+ Partials       1259     1258       -1     
Impacted Files Coverage Δ
...agement/indexstatemanagement/ManagedIndexRunner.kt 46.18% <ø> (+0.10%) ⬆️
...ndexstatemanagement/IndexStateManagementHistory.kt 80.00% <50.00%> (ø)
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 68.71% <100.00%> (-0.59%) ⬇️
...t/indexstatemanagement/model/ManagedIndexConfig.kt 81.13% <100.00%> (ø)
...ndexstatemanagement/step/close/AttemptCloseStep.kt 91.48% <100.00%> (ø)
...gement/transform/model/ContinuousTransformStats.kt 70.37% <0.00%> (-3.71%) ⬇️
.../action/explain/TransportExplainTransformAction.kt 70.78% <0.00%> (-2.25%) ⬇️
...management/indexstatemanagement/MetadataService.kt 62.68% <0.00%> (-2.24%) ⬇️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 85.58% <0.00%> (-0.47%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@khushbr khushbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You for cleaning up the code, does this change require updating any tests or supplementary documentation?

@deshsidd
Copy link
Contributor Author

deshsidd commented Oct 6, 2022

Thank You for cleaning up the code, does this change require updating any tests or supplementary documentation?

The tests should not need any changes. Where can I check if the documentation needs to be updated? Do I need to manually go over the OpenSearch public documentation?

@deshsidd deshsidd merged commit efe2d33 into opensearch-project:main Oct 6, 2022
bowenlan-amzn pushed a commit to bowenlan-amzn/index-management that referenced this pull request Nov 10, 2022
* Fix low hanging fruit warnings

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Revert change causing IT failure

Signed-off-by: Siddhant Deshmukh <[email protected]>

Signed-off-by: Siddhant Deshmukh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants