Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi rollup ndx search #453

Merged

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Aug 8, 2022

Issue #, if available:
#321

Description of changes:

Added integration tests

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz petardz requested a review from a team August 8, 2022 22:33
@codecov-commenter
Copy link

Codecov Report

Merging #453 (1b9fb8b) into main (b8a77d4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #453   +/-   ##
=========================================
  Coverage     75.76%   75.76%           
+ Complexity     2470     2466    -4     
=========================================
  Files           314      314           
  Lines         14440    14440           
  Branches       2233     2233           
=========================================
  Hits          10940    10940           
+ Misses         2255     2250    -5     
- Partials       1245     1250    +5     
Impacted Files Coverage Δ
...ent/rollup/action/explain/ExplainRollupResponse.kt 76.19% <0.00%> (-9.53%) ⬇️
...gement/indexstatemanagement/action/ShrinkAction.kt 66.17% <0.00%> (-5.89%) ⬇️
...gement/transform/model/ContinuousTransformStats.kt 70.37% <0.00%> (-3.71%) ⬇️
...rch/indexmanagement/rollup/model/RollupMetadata.kt 84.30% <0.00%> (-1.75%) ⬇️
.../rollup/action/start/TransportStartRollupAction.kt 71.76% <0.00%> (-1.18%) ⬇️
...nt/rollup/action/stop/TransportStopRollupAction.kt 76.47% <0.00%> (-1.18%) ⬇️
...earch/indexmanagement/transform/model/Transform.kt 85.47% <0.00%> (-0.43%) ⬇️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 86.04% <0.00%> (ø)
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 69.29% <0.00%> (ø)
...ent/indexstatemanagement/util/ManagedIndexUtils.kt 77.87% <0.00%> (+1.76%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bowenlan-amzn bowenlan-amzn merged commit af5b366 into opensearch-project:main Aug 9, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 9, 2022
* added support for searching multiple rollup indices with same mapping

Signed-off-by: Petar Dzepina <[email protected]>

* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <[email protected]>

* reverted old error messages

Signed-off-by: Petar Dzepina <[email protected]>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <[email protected]>

* fixed sorting

Signed-off-by: petar.dzepina <[email protected]>

* added ITs for multi rollup index search

Signed-off-by: petardz <[email protected]>

* added ITs for multi rollup index search#2

Signed-off-by: petardz <[email protected]>

* detekt fixes

Signed-off-by: petardz <[email protected]>

* changed index names and rollup job

Signed-off-by: petardz <[email protected]>

* detekt fix

Signed-off-by: petardz <[email protected]>

* empty commit to trigger test pipeline

Signed-off-by: petardz <[email protected]>

Co-authored-by: petar.dzepina <[email protected]>
(cherry picked from commit af5b366)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 9, 2022
* added support for searching multiple rollup indices with same mapping

Signed-off-by: Petar Dzepina <[email protected]>

* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <[email protected]>

* reverted old error messages

Signed-off-by: Petar Dzepina <[email protected]>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <[email protected]>

* fixed sorting

Signed-off-by: petar.dzepina <[email protected]>

* added ITs for multi rollup index search

Signed-off-by: petardz <[email protected]>

* added ITs for multi rollup index search#2

Signed-off-by: petardz <[email protected]>

* detekt fixes

Signed-off-by: petardz <[email protected]>

* changed index names and rollup job

Signed-off-by: petardz <[email protected]>

* detekt fix

Signed-off-by: petardz <[email protected]>

* empty commit to trigger test pipeline

Signed-off-by: petardz <[email protected]>

Co-authored-by: petar.dzepina <[email protected]>
(cherry picked from commit af5b366)
bowenlan-amzn pushed a commit that referenced this pull request Aug 9, 2022
* added support for searching multiple rollup indices with same mapping

Signed-off-by: Petar Dzepina <[email protected]>

* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <[email protected]>

* reverted old error messages

Signed-off-by: Petar Dzepina <[email protected]>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <[email protected]>

* fixed sorting

Signed-off-by: petar.dzepina <[email protected]>

* added ITs for multi rollup index search

Signed-off-by: petardz <[email protected]>

* added ITs for multi rollup index search#2

Signed-off-by: petardz <[email protected]>

* detekt fixes

Signed-off-by: petardz <[email protected]>

* changed index names and rollup job

Signed-off-by: petardz <[email protected]>

* detekt fix

Signed-off-by: petardz <[email protected]>

* empty commit to trigger test pipeline

Signed-off-by: petardz <[email protected]>

Co-authored-by: petar.dzepina <[email protected]>
(cherry picked from commit af5b366)

Co-authored-by: Petar Dzepina <[email protected]>
petardz added a commit to petardz/index-management that referenced this pull request Aug 9, 2022
* added support for searching multiple rollup indices with same mapping
* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <[email protected]>

* reverted old error messages

Signed-off-by: Petar Dzepina <[email protected]>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <[email protected]>

* fixed sorting
* added ITs for multi rollup index search
* added ITs for multi rollup index search#2
* detekt fixes
* changed index names and rollup job
* detekt fix
* empty commit to trigger test pipeline

Signed-off-by: Petar Dzepina <[email protected]>
petardz added a commit to petardz/index-management that referenced this pull request Aug 10, 2022
* fixed failing rollupInterceptorIT  test
* reverted old error messages
* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic
* fixed sorting
* added ITs for multi rollup index search
* added ITs for multi rollup index search#2
* detekt fixes
* changed index names and rollup job
* detekt fix
* empty commit to trigger test pipeline

Signed-off-by: Petar Dzepina <[email protected]>
petardz added a commit to petardz/index-management that referenced this pull request Aug 10, 2022
* fixed failing rollupInterceptorIT  test
* reverted old error messages
* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic
* fixed sorting
* added ITs for multi rollup index search
* added ITs for multi rollup index search#2
* detekt fixes
* changed index names and rollup job
* detekt fix
* empty commit to trigger test pipeline

Signed-off-by: Petar Dzepina <[email protected]>
@Angie-Zhang Angie-Zhang mentioned this pull request Sep 9, 2022
1 task
Angie-Zhang pushed a commit to Angie-Zhang/index-management that referenced this pull request Sep 12, 2022
)

* added support for searching multiple rollup indices with same mapping

Signed-off-by: Petar Dzepina <[email protected]>

* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <[email protected]>

* reverted old error messages

Signed-off-by: Petar Dzepina <[email protected]>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <[email protected]>

* fixed sorting

Signed-off-by: petar.dzepina <[email protected]>

* added ITs for multi rollup index search

Signed-off-by: petardz <[email protected]>

* added ITs for multi rollup index search#2

Signed-off-by: petardz <[email protected]>

* detekt fixes

Signed-off-by: petardz <[email protected]>

* changed index names and rollup job

Signed-off-by: petardz <[email protected]>

* detekt fix

Signed-off-by: petardz <[email protected]>

* empty commit to trigger test pipeline

Signed-off-by: petardz <[email protected]>

Co-authored-by: petar.dzepina <[email protected]>
(cherry picked from commit af5b366)

Co-authored-by: Petar Dzepina <[email protected]>
Signed-off-by: Angie Zhang <[email protected]>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
)

* added support for searching multiple rollup indices with same mapping

Signed-off-by: Petar Dzepina <[email protected]>

* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <[email protected]>

* reverted old error messages

Signed-off-by: Petar Dzepina <[email protected]>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <[email protected]>

* fixed sorting

Signed-off-by: petar.dzepina <[email protected]>

* added ITs for multi rollup index search

Signed-off-by: petardz <[email protected]>

* added ITs for multi rollup index search#2

Signed-off-by: petardz <[email protected]>

* detekt fixes

Signed-off-by: petardz <[email protected]>

* changed index names and rollup job

Signed-off-by: petardz <[email protected]>

* detekt fix

Signed-off-by: petardz <[email protected]>

* empty commit to trigger test pipeline

Signed-off-by: petardz <[email protected]>

Co-authored-by: petar.dzepina <[email protected]>
(cherry picked from commit af5b366)

Co-authored-by: Petar Dzepina <[email protected]>
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
)

* added support for searching multiple rollup indices with same mapping

Signed-off-by: Petar Dzepina <[email protected]>

* fixed failing rollupInterceptorIT  test

Signed-off-by: Petar Dzepina <[email protected]>

* reverted old error messages

Signed-off-by: Petar Dzepina <[email protected]>

* reverted checking for matching jobs on whole set instead of job by job; Added picking rollup job deterministic

Signed-off-by: petar.dzepina <[email protected]>

* fixed sorting

Signed-off-by: petar.dzepina <[email protected]>

* added ITs for multi rollup index search

Signed-off-by: petardz <[email protected]>

* added ITs for multi rollup index search#2

Signed-off-by: petardz <[email protected]>

* detekt fixes

Signed-off-by: petardz <[email protected]>

* changed index names and rollup job

Signed-off-by: petardz <[email protected]>

* detekt fix

Signed-off-by: petardz <[email protected]>

* empty commit to trigger test pipeline

Signed-off-by: petardz <[email protected]>

Co-authored-by: petar.dzepina <[email protected]>
(cherry picked from commit af5b366)

Co-authored-by: Petar Dzepina <[email protected]>
Signed-off-by: Ronnak Saxena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants