removed recursion from Explain Action to avoid stackoverflow in some … #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…situations Signed-off-by: Petar Dzepina <[email protected]>
|
Looks great Petar, thanks! |
downsrob
approved these changes
Jul 19, 2022
getsaurabh02
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Thanks for the changes. This looks much cleaner and simpler now.
Also, lets follow up separately on a new issue to discuss the potential alternatives to the TransportManagedIndexAction as suggested in the previous comment.
| for (i in 0 until indexNames.count()) { | ||
| val request = ManagedIndexRequest().indices(indexNames[i]) | ||
| try { | ||
| client.suspendUntil<NodeClient, AcknowledgedResponse> { execute(ManagedIndexAction.INSTANCE, request, it) } |
There was a problem hiding this comment.
Although this will solve the stack overflow issue, I still see the multiple calls for TransportManagedIndexAction for every index as a potential problem and bottleneck for the clusters with large number of indices. It could still block the primary (transport) worker thread until all the transport action calls succeeds or fails for every index and could lead to starvation issue.
The non operational transport action that is used by ISM to check if the user has required index permissions to manage index in form of TransportManagedIndexAction seems to be a workaround due to lack of better ways for mapping user permission with indices.
I will prefer instrumenting some cleaner and direct ways of identifying index permissions for the user. This is outside the scope of this PR, but we should open an issue and follow up separately on the possible approaches.
There was a problem hiding this comment.
Created #422 so that we don't miss out on this and look into this at priority.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…situations (#419) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…situations (#419) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976)
downsrob
pushed a commit
that referenced
this pull request
Jul 20, 2022
…situations (#419) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976)
downsrob
pushed a commit
that referenced
this pull request
Jul 20, 2022
…situations (#419) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976)
bowenlan-amzn
pushed a commit
that referenced
this pull request
Jul 21, 2022
…situations (#419) (#420) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976) Co-authored-by: Petar Dzepina <[email protected]>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Jul 21, 2022
…situations (#419) (#421) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976) Co-authored-by: Petar Dzepina <[email protected]>
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Jul 21, 2022
…situations (#419) (#420) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976) Co-authored-by: Petar Dzepina <[email protected]> (cherry picked from commit 4df1b41)
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Jul 21, 2022
…situations (#419) (#421) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976) Co-authored-by: Petar Dzepina <[email protected]> (cherry picked from commit b63320b)
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Jul 21, 2022
…situations (#419) (#421) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976) Co-authored-by: Petar Dzepina <[email protected]> (cherry picked from commit b63320b)
downsrob
pushed a commit
that referenced
this pull request
Jul 27, 2022
…situations (#419) (#421) (#425) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976) Co-authored-by: Petar Dzepina <[email protected]> (cherry picked from commit b63320b) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
downsrob
pushed a commit
that referenced
this pull request
Jul 27, 2022
…situations (#419) (#420) (#424) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976) Co-authored-by: Petar Dzepina <[email protected]> (cherry picked from commit 4df1b41) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Jul 28, 2022
…situations (#419) (#421) (#426) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976) Co-authored-by: Petar Dzepina <[email protected]> (cherry picked from commit b63320b) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
ronnaksaxena
pushed a commit
to ronnaksaxena/index-management
that referenced
this pull request
Jul 29, 2022
…situations (opensearch-project#419) Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Ronnak Saxena <[email protected]>
jowg-amazon
pushed a commit
to jowg-amazon/index-management
that referenced
this pull request
Aug 18, 2022
…situations (opensearch-project#419) Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Joanne Wang <[email protected]>
Angie-Zhang
pushed a commit
to Angie-Zhang/index-management
that referenced
this pull request
Sep 12, 2022
…situations (opensearch-project#419) (opensearch-project#421) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976) Co-authored-by: Petar Dzepina <[email protected]> Signed-off-by: Angie Zhang <[email protected]>
Angie-Zhang
added a commit
that referenced
this pull request
Oct 14, 2022
* initial framework Signed-off-by: Joanne Wang <[email protected]> * Removed recursion from Explain Action to avoid stackoverflow in some situations (#419) Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Joanne Wang <[email protected]> * enabled by default integrated Signed-off-by: Joanne Wang <[email protected]> * cleaned up comments and logs, created unit test and updated previous integration tests Signed-off-by: Joanne Wang <[email protected]> * added delete validation logic Signed-off-by: Joanne Wang <[email protected]> * fixed rollover validation unit tests Signed-off-by: Joanne Wang <[email protected]> * added validation info field to ManagedIndexMetaData Signed-off-by: Joanne Wang <[email protected]> * removed step context as input Signed-off-by: Joanne Wang <[email protected]> * added validationmetadata class Signed-off-by: Joanne Wang <[email protected]> * restored old integration tests and changed validation service output Signed-off-by: Joanne Wang <[email protected]> * before integrated validation meta data into managed index meta data Signed-off-by: Joanne Wang <[email protected]> * integrated validation meta data Signed-off-by: Joanne Wang <[email protected]> * working version Signed-off-by: Joanne Wang <[email protected]> * added validation mapping Signed-off-by: Joanne Wang <[email protected]> * fixed integ tests Signed-off-by: Joanne Wang <[email protected]> * renamed some values Signed-off-by: Joanne Wang <[email protected]> * before removing from managed index meta data Signed-off-by: Joanne Wang <[email protected]> * created validation result object in explain Signed-off-by: Joanne Wang <[email protected]> * testing Signed-off-by: Joanne Wang <[email protected]> * run fails Signed-off-by: Joanne Wang <[email protected]> * integration test for delete + added framework for force merge Signed-off-by: Joanne Wang <[email protected]> * removed step validation metadata and still testing explain results Signed-off-by: Joanne Wang <[email protected]> * before removing from managed index runner Signed-off-by: Joanne Wang <[email protected]> * removed from managed index runner Signed-off-by: Joanne Wang <[email protected]> * clean up and tests Signed-off-by: Joanne Wang <[email protected]> * all validation tests pass Signed-off-by: Joanne Wang <[email protected]> * removed validation result from all managed index meta data Signed-off-by: Joanne Wang <[email protected]> * restored old IT tests Signed-off-by: Joanne Wang <[email protected]> * fixed it tests, set explain validation to false Signed-off-by: Joanne Wang <[email protected]> * clean up Signed-off-by: Joanne Wang <[email protected]> * Change test page size to avoid index/search TimeInMillis < 1 issue. (#460) * Change test page size to avoid indexTimeInMillis < 1 issue. Signed-off-by: Angie Zhang <[email protected]> * Change test page size to avoid indexTimeInMillis < 1 issue. Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Angie Zhang <[email protected]> * Transform maxclauses fix (#477) * transform maxClauses fix Signed-off-by: Petar Dzepina <[email protected]> * added bucket log to track processed buckets Signed-off-by: Petar Dzepina <[email protected]> * various renames/changes Signed-off-by: Petar Dzepina <[email protected]> * fixed detekt issues Signed-off-by: Petar Dzepina <[email protected]> * added comments to test Signed-off-by: Petar Dzepina <[email protected]> * removed debug logging Signed-off-by: Petar Dzepina <[email protected]> * empty commit to trigger checks Signed-off-by: Petar Dzepina <[email protected]> * reduced pageSize to 1 in few ITs to avoid flaky tests; fixed bug where pagesProcessed was calculated incorrectly Signed-off-by: Petar Dzepina <[email protected]> * reverted pagesProcessed change; fixed few ITs Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> * 483: Updated detekt plugin and snakeyaml dependency. Updated a code t… (#485) * 483: Updated detekt plugin and snakeyaml dependency. Updated a code to reduce the number of issues after static analysis Signed-off-by: Stevan Buzejic <[email protected]> * 483: Updated snakeyaml version to use the latest Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> * Remove HOST_DENY_LIST usage as Notification plugin will own it (#471) (#107) Signed-off-by: Xuesong Luo <[email protected]> Signed-off-by: Xuesong Luo <[email protected]> * Disable detekt because of the CVE (#497) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> * Deprecate Master nonmenclature (#501) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> * [AUTO] Increment version to 2.3.0-SNAPSHOT (#484) (#503) * fix#921-README-forum-link-index_mgmnt (#499) Signed-off-by: cwillum <[email protected]> Signed-off-by: cwillum <[email protected]> * 64: Added rounding when using aggreagate script for avg metric. Added… (#490) * 64: Added rounding when using aggreagate script for avg metric. Added unit tests for checking average aggregations against the target rollup index Signed-off-by: Stevan Buzejic <[email protected]> * 64: Rollup job renamed Signed-off-by: Stevan Buzejic <[email protected]> * 64: Removed unrelevant metrics for the avg calculation test Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> * Revert Disable detekt and force choose snakeyml 1.32 (#528) * Revert Disable detekt: 50ac1e9 Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove force choosing snakeyml 1.31 Signed-off-by: Siddhant Deshmukh <[email protected]> * Force snakeyaml 1.32 Signed-off-by: Siddhant Deshmukh <[email protected]> * Empty commit Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]> * Added 2.3 release note (#507) (#515) (#517) * Update 2.3 release note Signed-off-by: Angie Zhang <[email protected]> * Update 2.3 release note Signed-off-by: Angie Zhang <[email protected]> * Update 2.3 release note Signed-off-by: Angie Zhang <[email protected]> * Update 2.3 release note Signed-off-by: Angie Zhang <[email protected]> * Update 2.3 release note Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Angie Zhang <[email protected]> (cherry picked from commit d9793ac) Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Angie Zhang <[email protected]> (cherry picked from commit 7217b5b) Co-authored-by: Angie Zhang <[email protected]> * Add 2.2 release note (#450) (#452) (#516) * Add 2.2 release note Signed-off-by: Angie Zhang <[email protected]> * Add 2.2 release note Signed-off-by: Angie Zhang <[email protected]> Co-authored-by: Angie Zhang <[email protected]> (cherry picked from commit 8eb5da6) Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Angie Zhang <[email protected]> Co-authored-by: Ashish Agrawal <[email protected]> * Adds plugin version sweep background job (#434) * [207]: Added 5 min scheduled job for sweeping ISM plugin version in the case of version discrepancy Signed-off-by: Stevan Buzejic <[email protected]> * [207]: Created pluginVersionSweepCoordinator component responsible for scheduling the skip execution task. Annotated tests in order to prevent thread leak error during integrational tests Signed-off-by: Stevan Buzejic <[email protected]> * [207]: Increased retry period for background job that sets the skip flag up to 5 mins Signed-off-by: Stevan Buzejic <[email protected]> * Empty-Commit Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> Co-authored-by: Stevan Buzejic <[email protected]> * flaky transform test fix attempt (#542) * flaky transform test fix attempt Signed-off-by: Petar Dzepina <[email protected]> * accidental paste fix Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Co-authored-by: Petar Dzepina <[email protected]> Signed-off-by: Joanne Wang <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Xuesong Luo <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: cwillum <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Co-authored-by: Petar <[email protected]> Co-authored-by: Angie Zhang <[email protected]> Co-authored-by: Stevan Buzejic <[email protected]> Co-authored-by: xluo-aws <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Chris Moore <[email protected]> Co-authored-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Angie Zhang <[email protected]> Co-authored-by: Ashish Agrawal <[email protected]> Co-authored-by: Clay Downs <[email protected]> Co-authored-by: Stevan Buzejic <[email protected]> Co-authored-by: Petar Dzepina <[email protected]>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Nov 3, 2022
* initial framework Signed-off-by: Joanne Wang <[email protected]> * Removed recursion from Explain Action to avoid stackoverflow in some situations (#419) Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Joanne Wang <[email protected]> * enabled by default integrated Signed-off-by: Joanne Wang <[email protected]> * cleaned up comments and logs, created unit test and updated previous integration tests Signed-off-by: Joanne Wang <[email protected]> * added delete validation logic Signed-off-by: Joanne Wang <[email protected]> * fixed rollover validation unit tests Signed-off-by: Joanne Wang <[email protected]> * added validation info field to ManagedIndexMetaData Signed-off-by: Joanne Wang <[email protected]> * removed step context as input Signed-off-by: Joanne Wang <[email protected]> * added validationmetadata class Signed-off-by: Joanne Wang <[email protected]> * restored old integration tests and changed validation service output Signed-off-by: Joanne Wang <[email protected]> * before integrated validation meta data into managed index meta data Signed-off-by: Joanne Wang <[email protected]> * integrated validation meta data Signed-off-by: Joanne Wang <[email protected]> * working version Signed-off-by: Joanne Wang <[email protected]> * added validation mapping Signed-off-by: Joanne Wang <[email protected]> * fixed integ tests Signed-off-by: Joanne Wang <[email protected]> * renamed some values Signed-off-by: Joanne Wang <[email protected]> * before removing from managed index meta data Signed-off-by: Joanne Wang <[email protected]> * created validation result object in explain Signed-off-by: Joanne Wang <[email protected]> * testing Signed-off-by: Joanne Wang <[email protected]> * run fails Signed-off-by: Joanne Wang <[email protected]> * integration test for delete + added framework for force merge Signed-off-by: Joanne Wang <[email protected]> * removed step validation metadata and still testing explain results Signed-off-by: Joanne Wang <[email protected]> * before removing from managed index runner Signed-off-by: Joanne Wang <[email protected]> * removed from managed index runner Signed-off-by: Joanne Wang <[email protected]> * clean up and tests Signed-off-by: Joanne Wang <[email protected]> * all validation tests pass Signed-off-by: Joanne Wang <[email protected]> * removed validation result from all managed index meta data Signed-off-by: Joanne Wang <[email protected]> * restored old IT tests Signed-off-by: Joanne Wang <[email protected]> * fixed it tests, set explain validation to false Signed-off-by: Joanne Wang <[email protected]> * clean up Signed-off-by: Joanne Wang <[email protected]> * Implemented replica_count, open, read_only, read_write Signed-off-by: Angie Zhang <[email protected]> * Implemented replica_count, open, read_only, read_write Signed-off-by: Angie Zhang <[email protected]> * Fix Test cases Signed-off-by: Angie Zhang <[email protected]> * Fix Test cases Signed-off-by: Angie Zhang <[email protected]> * Fix messages Signed-off-by: Angie Zhang <[email protected]> * Fix comments; set validation disabled by default Signed-off-by: Angie Zhang <[email protected]> * Rename validation_service to action_validation; Fix some detekt issues Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Joanne Wang <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Angie Zhang <[email protected]> Co-authored-by: Joanne Wang <[email protected]> Co-authored-by: Petar <[email protected]> Co-authored-by: Joanne Wang <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
* initial framework Signed-off-by: Joanne Wang <[email protected]> * Removed recursion from Explain Action to avoid stackoverflow in some situations (#419) Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Joanne Wang <[email protected]> * enabled by default integrated Signed-off-by: Joanne Wang <[email protected]> * cleaned up comments and logs, created unit test and updated previous integration tests Signed-off-by: Joanne Wang <[email protected]> * added delete validation logic Signed-off-by: Joanne Wang <[email protected]> * fixed rollover validation unit tests Signed-off-by: Joanne Wang <[email protected]> * added validation info field to ManagedIndexMetaData Signed-off-by: Joanne Wang <[email protected]> * removed step context as input Signed-off-by: Joanne Wang <[email protected]> * added validationmetadata class Signed-off-by: Joanne Wang <[email protected]> * restored old integration tests and changed validation service output Signed-off-by: Joanne Wang <[email protected]> * before integrated validation meta data into managed index meta data Signed-off-by: Joanne Wang <[email protected]> * integrated validation meta data Signed-off-by: Joanne Wang <[email protected]> * working version Signed-off-by: Joanne Wang <[email protected]> * added validation mapping Signed-off-by: Joanne Wang <[email protected]> * fixed integ tests Signed-off-by: Joanne Wang <[email protected]> * renamed some values Signed-off-by: Joanne Wang <[email protected]> * before removing from managed index meta data Signed-off-by: Joanne Wang <[email protected]> * created validation result object in explain Signed-off-by: Joanne Wang <[email protected]> * testing Signed-off-by: Joanne Wang <[email protected]> * run fails Signed-off-by: Joanne Wang <[email protected]> * integration test for delete + added framework for force merge Signed-off-by: Joanne Wang <[email protected]> * removed step validation metadata and still testing explain results Signed-off-by: Joanne Wang <[email protected]> * before removing from managed index runner Signed-off-by: Joanne Wang <[email protected]> * removed from managed index runner Signed-off-by: Joanne Wang <[email protected]> * clean up and tests Signed-off-by: Joanne Wang <[email protected]> * all validation tests pass Signed-off-by: Joanne Wang <[email protected]> * removed validation result from all managed index meta data Signed-off-by: Joanne Wang <[email protected]> * restored old IT tests Signed-off-by: Joanne Wang <[email protected]> * fixed it tests, set explain validation to false Signed-off-by: Joanne Wang <[email protected]> * clean up Signed-off-by: Joanne Wang <[email protected]> * Implemented replica_count, open, read_only, read_write Signed-off-by: Angie Zhang <[email protected]> * Implemented replica_count, open, read_only, read_write Signed-off-by: Angie Zhang <[email protected]> * Fix Test cases Signed-off-by: Angie Zhang <[email protected]> * Fix Test cases Signed-off-by: Angie Zhang <[email protected]> * Fix messages Signed-off-by: Angie Zhang <[email protected]> * Fix comments; set validation disabled by default Signed-off-by: Angie Zhang <[email protected]> * Rename validation_service to action_validation; Fix some detekt issues Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Joanne Wang <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Angie Zhang <[email protected]> Co-authored-by: Joanne Wang <[email protected]> Co-authored-by: Petar <[email protected]> Co-authored-by: Joanne Wang <[email protected]> (cherry picked from commit 2438f48)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
* initial framework Signed-off-by: Joanne Wang <[email protected]> * Removed recursion from Explain Action to avoid stackoverflow in some situations (#419) Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Joanne Wang <[email protected]> * enabled by default integrated Signed-off-by: Joanne Wang <[email protected]> * cleaned up comments and logs, created unit test and updated previous integration tests Signed-off-by: Joanne Wang <[email protected]> * added delete validation logic Signed-off-by: Joanne Wang <[email protected]> * fixed rollover validation unit tests Signed-off-by: Joanne Wang <[email protected]> * added validation info field to ManagedIndexMetaData Signed-off-by: Joanne Wang <[email protected]> * removed step context as input Signed-off-by: Joanne Wang <[email protected]> * added validationmetadata class Signed-off-by: Joanne Wang <[email protected]> * restored old integration tests and changed validation service output Signed-off-by: Joanne Wang <[email protected]> * before integrated validation meta data into managed index meta data Signed-off-by: Joanne Wang <[email protected]> * integrated validation meta data Signed-off-by: Joanne Wang <[email protected]> * working version Signed-off-by: Joanne Wang <[email protected]> * added validation mapping Signed-off-by: Joanne Wang <[email protected]> * fixed integ tests Signed-off-by: Joanne Wang <[email protected]> * renamed some values Signed-off-by: Joanne Wang <[email protected]> * before removing from managed index meta data Signed-off-by: Joanne Wang <[email protected]> * created validation result object in explain Signed-off-by: Joanne Wang <[email protected]> * testing Signed-off-by: Joanne Wang <[email protected]> * run fails Signed-off-by: Joanne Wang <[email protected]> * integration test for delete + added framework for force merge Signed-off-by: Joanne Wang <[email protected]> * removed step validation metadata and still testing explain results Signed-off-by: Joanne Wang <[email protected]> * before removing from managed index runner Signed-off-by: Joanne Wang <[email protected]> * removed from managed index runner Signed-off-by: Joanne Wang <[email protected]> * clean up and tests Signed-off-by: Joanne Wang <[email protected]> * all validation tests pass Signed-off-by: Joanne Wang <[email protected]> * removed validation result from all managed index meta data Signed-off-by: Joanne Wang <[email protected]> * restored old IT tests Signed-off-by: Joanne Wang <[email protected]> * fixed it tests, set explain validation to false Signed-off-by: Joanne Wang <[email protected]> * clean up Signed-off-by: Joanne Wang <[email protected]> * Implemented replica_count, open, read_only, read_write Signed-off-by: Angie Zhang <[email protected]> * Implemented replica_count, open, read_only, read_write Signed-off-by: Angie Zhang <[email protected]> * Fix Test cases Signed-off-by: Angie Zhang <[email protected]> * Fix Test cases Signed-off-by: Angie Zhang <[email protected]> * Fix messages Signed-off-by: Angie Zhang <[email protected]> * Fix comments; set validation disabled by default Signed-off-by: Angie Zhang <[email protected]> * Rename validation_service to action_validation; Fix some detekt issues Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Joanne Wang <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Angie Zhang <[email protected]> Co-authored-by: Joanne Wang <[email protected]> Co-authored-by: Petar <[email protected]> Co-authored-by: Joanne Wang <[email protected]> (cherry picked from commit 2438f48)
khushbr
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Error prevention stage 1 * Removed recursion from Explain Action to avoid stackoverflow in some situations (#419) * enabled by default integrated * Fix Test cases * Fix comments; set validation disabled by default * Rename validation_service to action_validation; Fix some detekt issues Signed-off-by: Joanne Wang <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Angie Zhang <[email protected]> Co-authored-by: Joanne Wang <[email protected]> Co-authored-by: Petar <[email protected]> Co-authored-by: Angie Zhang <[email protected]>
khushbr
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Removed recursion from Explain Action to avoid stackoverflow in some situations (#419) * enabled by default integrated * Fix Test cases * Fix comments; set validation disabled by default * Rename validation_service to action_validation; Fix some detekt issues Signed-off-by: Joanne Wang <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Angie Zhang <[email protected]> Co-authored-by: Joanne Wang <[email protected]> Co-authored-by: Petar <[email protected]> Co-authored-by: Angie Zhang <[email protected]>
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
…situations (opensearch-project#419) (opensearch-project#421) Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 76de976) Co-authored-by: Petar Dzepina <[email protected]>
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
…#591) * Error prevention stage 1 * Removed recursion from Explain Action to avoid stackoverflow in some situations (opensearch-project#419) * enabled by default integrated * Fix Test cases * Fix comments; set validation disabled by default * Rename validation_service to action_validation; Fix some detekt issues Signed-off-by: Joanne Wang <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Angie Zhang <[email protected]> Co-authored-by: Joanne Wang <[email protected]> Co-authored-by: Petar <[email protected]> Co-authored-by: Angie Zhang <[email protected]>
ronnaksaxena
pushed a commit
to ronnaksaxena/index-management
that referenced
this pull request
Jul 19, 2023
…#591) * Error prevention stage 1 * Removed recursion from Explain Action to avoid stackoverflow in some situations (opensearch-project#419) * enabled by default integrated * Fix Test cases * Fix comments; set validation disabled by default * Rename validation_service to action_validation; Fix some detekt issues Signed-off-by: Joanne Wang <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Angie Zhang <[email protected]> Co-authored-by: Joanne Wang <[email protected]> Co-authored-by: Petar <[email protected]> Co-authored-by: Angie Zhang <[email protected]> Signed-off-by: Ronnak Saxena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…situations
Signed-off-by: Petar Dzepina [email protected]
Issue #, if available:
#410
#414
Description of changes:
Removed recursion from Explain Action to avoid stack overflow bug when there's few hundreds+ managed indexes present
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.