Replace checked-in ZIPs with dynamic dependencies #327
Conversation
Signed-off-by: Clay Downs <[email protected]>
downsrob
changed the title
Signed-off-by: Clay Downs <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
============================================
- Coverage 76.71% 76.64% -0.07%
+ Complexity 2044 2043 -1
============================================
Files 253 253
Lines 11636 11636
Branches 1807 1807
============================================
- Hits 8926 8918 -8
- Misses 1742 1746 +4
- Partials 968 972 +4
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| // Download the job scheduler test dependency | ||
| getPluginResource(job_scheduler_resource_folder, job_scheduler_build_download) |
There was a problem hiding this comment.
does this mean this method will be called for all gradle tasks?
There was a problem hiding this comment.
That's right. I believe that we also initialize the integTest clusters with the plugin zips for all targets in the configuration phase, so to get around downloading the resource always, we would need to refactor the cluster setup, which I didn't have time to take on at this point
There was a problem hiding this comment.
got it, lets create an issue for this - we don't need to address it immediately
…#327) * Removes zip dependencies Signed-off-by: Clay Downs <[email protected]> * Removes mustache zip Signed-off-by: Clay Downs <[email protected]>
Signed-off-by: Clay Downs [email protected]
Issue #, if available:
#305
Description of changes:
Replace checked-in ZIPs with dynamic dependencies. The current job scheduler zip used for integration tests is downloaded from ci.opensearch.org. The backwards compatibility test job scheduler and index management versions are downloaded from https://github.com/opendistro-for-elasticsearch artifacts. These dependencies are downloaded during the gradle configuration phase, and will be refreshed with any task run.
Removes the mustache zip entirely, as I couldn't find any reference to it being used.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.