-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes custom action parsing #309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clay Downs <[email protected]>
dbbaughe
approved these changes
Mar 15, 2022
bowenlan-amzn
approved these changes
Mar 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
============================================
+ Coverage 75.55% 75.60% +0.05%
- Complexity 2001 2003 +2
============================================
Files 253 253
Lines 11467 11467
Branches 1815 1815
============================================
+ Hits 8664 8670 +6
+ Misses 1772 1764 -8
- Partials 1031 1033 +2
Continue to review full report at Codecov.
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
Signed-off-by: Clay Downs <[email protected]> (cherry picked from commit 901d887)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
Signed-off-by: Clay Downs <[email protected]> (cherry picked from commit 901d887)
downsrob
added a commit
that referenced
this pull request
Mar 15, 2022
Signed-off-by: Clay Downs <[email protected]> (cherry picked from commit 901d887) Co-authored-by: Clay Downs <[email protected]>
downsrob
added a commit
that referenced
this pull request
Mar 16, 2022
Signed-off-by: Clay Downs <[email protected]> (cherry picked from commit 901d887) Co-authored-by: Clay Downs <[email protected]>
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Clay Downs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Clay Downs [email protected]
Issue #, if available:
NA
Description of changes:
Fixes custom action parsing which was failing due to having the token assertions in the wrong order. Custom parsing was being tested exclusively through unit tests, and there was no unit test for actually parsing an extension action written out with the "custom" wrapper, adds that unit test.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.