Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes custom action parsing #309

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Conversation

downsrob
Copy link
Contributor

@downsrob downsrob commented Mar 15, 2022

Signed-off-by: Clay Downs [email protected]

Issue #, if available:
NA

Description of changes:
Fixes custom action parsing which was failing due to having the token assertions in the wrong order. Custom parsing was being tested exclusively through unit tests, and there was no unit test for actually parsing an extension action written out with the "custom" wrapper, adds that unit test.

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@downsrob downsrob marked this pull request as ready for review March 15, 2022 17:33
@downsrob downsrob requested a review from a team March 15, 2022 17:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #309 (045d79e) into main (6d93359) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #309      +/-   ##
============================================
+ Coverage     75.55%   75.60%   +0.05%     
- Complexity     2001     2003       +2     
============================================
  Files           253      253              
  Lines         11467    11467              
  Branches       1815     1815              
============================================
+ Hits           8664     8670       +6     
+ Misses         1772     1764       -8     
- Partials       1031     1033       +2     
Impacted Files Coverage Δ
...anagement/indexstatemanagement/ISMActionsParser.kt 88.52% <100.00%> (+8.19%) ⬆️
.../rollup/action/start/TransportStartRollupAction.kt 66.27% <0.00%> (-3.49%) ⬇️
...anagement/indexstatemanagement/model/Transition.kt 64.78% <0.00%> (-2.82%) ⬇️
...nt/rollup/action/stop/TransportStopRollupAction.kt 70.93% <0.00%> (-1.17%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 72.18% <0.00%> (-0.63%) ⬇️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 84.43% <0.00%> (-0.48%) ⬇️
...earch/indexmanagement/transform/model/Transform.kt 85.65% <0.00%> (+0.43%) ⬆️
...gement/transform/model/ContinuousTransformStats.kt 69.23% <0.00%> (+3.84%) ⬆️
.../opensearch/indexmanagement/rollup/RollupRunner.kt 69.91% <0.00%> (+4.42%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d93359...045d79e. Read the comment docs.

@downsrob downsrob merged commit 901d887 into opensearch-project:main Mar 15, 2022
@downsrob downsrob deleted the parsing-fix branch March 15, 2022 17:51
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2022
Signed-off-by: Clay Downs <[email protected]>
(cherry picked from commit 901d887)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2022
Signed-off-by: Clay Downs <[email protected]>
(cherry picked from commit 901d887)
downsrob added a commit that referenced this pull request Mar 15, 2022
Signed-off-by: Clay Downs <[email protected]>
(cherry picked from commit 901d887)

Co-authored-by: Clay Downs <[email protected]>
downsrob added a commit that referenced this pull request Mar 16, 2022
Signed-off-by: Clay Downs <[email protected]>
(cherry picked from commit 901d887)

Co-authored-by: Clay Downs <[email protected]>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants