Fix 2.x build due to bug fix on update settings requests on read only indices in core #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
bowenlan-amzn,
Hailong-am and
vikasvb90
as code owners
cwperks
changed the title
cwperks
changed the title
|
@bowenlan-amzn @Hailong-am @vikasvb90 Can I get a review of this PR? This fixes the build on 2.x to react to a change from OpenSearch core. |
bowenlan-amzn
approved these changes
Dec 12, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes build on 2.x. 2.x build started failing because of a bug fix in opensearch-project/OpenSearch#16568 related to how update settings requests were treated for read only indices.
This will help fix the bwc check on #1311
Related Issues
Resolves #1305 and #1304
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.