-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accepts https as a property to set securityEnabled flag #1100
Merged
bowenlan-amzn
merged 1 commit into
opensearch-project:main
from
DarshitChanpura:fix-securityEnabled-flag
Feb 8, 2024
Merged
Accepts https as a property to set securityEnabled flag #1100
bowenlan-amzn
merged 1 commit into
opensearch-project:main
from
DarshitChanpura:fix-securityEnabled-flag
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep,
AWSHurneyt,
jowg-amazon,
r1walz and
vikasvb90
as code owners
February 8, 2024 21:11
DarshitChanpura
added
backport 2.x
v2.12.0
Issues targeting release v2.12.0
backport 2.12
labels
Feb 8, 2024
@bowenlan-amzn @r1walz mind reviewing this one? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1100 +/- ##
============================================
- Coverage 75.37% 75.36% -0.01%
- Complexity 2813 2814 +1
============================================
Files 367 367
Lines 17038 17038
Branches 2370 2370
============================================
- Hits 12842 12841 -1
- Misses 2893 2894 +1
Partials 1303 1303 ☔ View full report in Codecov by Sentry. |
r1walz
approved these changes
Feb 8, 2024
bowenlan-amzn
approved these changes
Feb 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
(cherry picked from commit 5ff29d1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
(cherry picked from commit 5ff29d1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
88 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to [AUTOCUT] Integration Test failed for index-management: 2.12.0 tar distribution #1086
The error:
Upon investigation I discovered that the integration tests triggered by opensearch-build do not pass
security
as an inline argument, instead they passhttps
(code-line). This cause the index-management tests in RC builds runwith-security
to fail withNot a valid SSL/TLS record: NotSslRecordException
which translates to mismatch betweenhttp
vshttps
. The protocol is set here conditionally to https viasecurityEnabled
flag viaindex-management/build.gradle
Line 514 in bc10724
index-management/build.gradle
Line 331 in bc10724
This PR adds an additional check to toggle securityEnabled flag by checking if
https
was passed.CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.