Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Upgrade ktlint to mitigate CVE-2023-6378 #1098

Merged

Conversation

r1walz
Copy link
Collaborator

@r1walz r1walz commented Feb 8, 2024

Description of changes: backport #1095

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

vikasvb90
vikasvb90 previously approved these changes Feb 9, 2024
@r1walz r1walz force-pushed the backport-2.x-cve-2023-6378 branch 2 times, most recently from b967abc to b20c8ac Compare February 9, 2024 08:58
@r1walz r1walz force-pushed the backport-2.x-cve-2023-6378 branch from b20c8ac to b282d3e Compare February 9, 2024 09:04
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 171 lines in your changes are missing coverage. Please review.

Comparison is base (e768d3b) 74.99% compared to head (b282d3e) 75.09%.

Files Patch % Lines
...agement/indexstatemanagement/ManagedIndexRunner.kt 45.83% 10 Missing and 3 partials ⚠️
...action/removepolicy/TransportRemovePolicyAction.kt 50.00% 8 Missing ⚠️
...atemanagement/step/rollover/AttemptRolloverStep.kt 46.15% 2 Missing and 5 partials ⚠️
...xmanagement/snapshotmanagement/model/SMMetadata.kt 61.11% 6 Missing and 1 partial ⚠️
...management/indexstatemanagement/MetadataService.kt 66.66% 6 Missing ⚠️
...anagement/step/forcemerge/WaitForForceMergeStep.kt 25.00% 5 Missing and 1 partial ⚠️
...ent/controlcenter/notification/model/LRONConfig.kt 37.50% 5 Missing ⚠️
...action/changepolicy/TransportChangePolicyAction.kt 68.75% 5 Missing ⚠️
...dexmanagement/rollup/query/QueryStringQueryUtil.kt 44.44% 3 Missing and 2 partials ⚠️
...ndexmanagement/transform/TransformSearchService.kt 37.50% 4 Missing and 1 partial ⚠️
... and 67 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1098      +/-   ##
============================================
+ Coverage     74.99%   75.09%   +0.10%     
  Complexity     2904     2904              
============================================
  Files           372      372              
  Lines         17122    17160      +38     
  Branches       2474     2476       +2     
============================================
+ Hits          12840    12887      +47     
+ Misses         2911     2905       -6     
+ Partials       1371     1368       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vikasvb90 vikasvb90 self-requested a review February 9, 2024 10:47
@bowenlan-amzn bowenlan-amzn merged commit 2efac32 into opensearch-project:2.x Feb 9, 2024
30 checks passed
@r1walz r1walz deleted the backport-2.x-cve-2023-6378 branch February 9, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants