Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vikas as code owner #1097

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

vikasvb90
Copy link
Collaborator

@vikasvb90 vikasvb90 commented Feb 8, 2024

Description of changes:

Adding Vikas as a maintainer

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: vikasvb90 <[email protected]>
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (027509e) 74.90% compared to head (8b3bfbb) 74.95%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1097      +/-   ##
============================================
+ Coverage     74.90%   74.95%   +0.05%     
- Complexity     2812     2814       +2     
============================================
  Files           367      367              
  Lines         16522    16522              
  Branches       2363     2363              
============================================
+ Hits          12375    12384       +9     
+ Misses         2845     2836       -9     
  Partials       1302     1302              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r1walz
Copy link
Collaborator

r1walz commented Feb 8, 2024

@opensearch-project/admin please update permissions for @vikasvb90. Thanks.

@bbarani
Copy link
Member

bbarani commented Feb 8, 2024

@bbarani
Copy link
Member

bbarani commented Feb 8, 2024

@vikasvb90 @r1walz Can you update https://github.com/opensearch-project/index-management/blob/main/MAINTAINERS.md as well?

nm, I see it updated as part of this PR. I have added Vikas as maintainer now.

@r1walz r1walz merged commit 7b3f88e into opensearch-project:main Feb 8, 2024
30 of 31 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1097-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7b3f88ecb25fde1bbbaef7025f3f50697dda5f51
# Push it to GitHub
git push --set-upstream origin backport/backport-1097-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1097-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants