Fixes password assignment for integTest when using remote cluster #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <[email protected]>
|
Can one of the maintainers create a backport 2.12 label, so that this change gets backported to 2.12? |
DarshitChanpura
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep,
AWSHurneyt,
jowg-amazon and
r1walz
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1091 +/- ##
=========================================
Coverage 74.87% 74.87%
+ Complexity 2814 2811 -3
=========================================
Files 367 367
Lines 16522 16522
Branches 2363 2363
=========================================
Hits 12371 12371
- Misses 2847 2849 +2
+ Partials 1304 1302 -2 ☔ View full report in Codecov by Sentry. |
r1walz
approved these changes
Feb 7, 2024
bowenlan-amzn
approved these changes
Feb 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
) (cherry picked from commit 027509e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.12
# Create a new branch
git switch --create backport/backport-1091-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 027509e3c7ca25fd3f910d48dbd3456597d0a9e1
# Push it to GitHub
git push --set-upstream origin backport/backport-1091-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.12Then, create a pull request where the |
|
@DarshitChanpura |
DarshitChanpura
added a commit
to DarshitChanpura/index-management
that referenced
this pull request
Feb 7, 2024
…ensearch-project#1091) (cherry picked from commit 027509e)
Merged
1 task
|
@bowenlan-amzn created a manual backport to 2.12: #1094 |
DarshitChanpura
added a commit
to DarshitChanpura/index-management
that referenced
this pull request
Feb 7, 2024
…ensearch-project#1091) (cherry picked from commit 027509e) Signed-off-by: Darshit Chanpura <[email protected]>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Feb 8, 2024
88 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the password system property was already set the value of admin, this wouldn't be changed later. This was a flaw in #1088. This PR fixes that by doing conditional assignment at 1 place.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.