Alias index transform #1049
Open
Alias index transform #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
n-dohrmann
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep,
AWSHurneyt and
jowg-amazon
as code owners
Signed-off-by: n-dohrmann <[email protected]>
…anagement into alias_index_transform
Signed-off-by: n-dohrmann <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
=============================================
- Coverage 74.81% 62.64% -12.18%
+ Complexity 2810 2339 -471
=============================================
Files 367 367
Lines 16518 16527 +9
Branches 2362 2366 +4
=============================================
- Hits 12358 10353 -2005
- Misses 2857 5020 +2163
+ Partials 1303 1154 -149 ☔ View full report in Codecov by Sentry. |
| @@ -63,6 +65,20 @@ class TransformIndexer( | |||
| throw TransformIndexException("Failed to create the target index") | |||
| } | |||
| } | |||
| val writeIndexMetadata = clusterService.state().metadata.indicesLookup[targetIndex]!!.writeIndex | |||
There was a problem hiding this comment.
This line should inside the below if block?
| if (clusterService.state().metadata.hasAlias(targetIndex)) { | ||
| // return error if no write index with the alias | ||
| if (writeIndexMetadata == null) { | ||
| throw TransformIndexException("Target index alias has no write index") |
There was a problem hiding this comment.
target_index [$targetIndex] is an alias but doesn't have write index
Comment on lines
75
to
81
| val putMappingReq = PutMappingRequest(writeIndexMetadata?.index?.name).source(targetFieldMappings) | ||
| val mapResp: AcknowledgedResponse = client.admin().indices().suspendUntil { | ||
| putMapping(putMappingReq) | ||
| } | ||
| if (!mapResp.isAcknowledged) { | ||
| logger.error("Target index mapping request failed") | ||
| } |
There was a problem hiding this comment.
Also move this inside to above if block?
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
…anagement into alias_index_transform
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
Signed-off-by: n-dohrmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#656
Description of changes:
Adding to
createTargetIndexmethod in theTransformIndexermodule - want to support using aliases for variable target indices on transform jobs.CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.