Backport 1000 #1009
Merged
Backport 1000 #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add more error notification at fail points Signed-off-by: bowenlan-amzn <[email protected]> * Handle exception gracefully Signed-off-by: bowenlan-amzn <[email protected]> * small fix Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: bowenlan-amzn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #1009 +/- ##
============================================
+ Coverage 75.04% 75.07% +0.03%
- Complexity 2882 2887 +5
============================================
Files 371 371
Lines 16936 16958 +22
Branches 2445 2447 +2
============================================
+ Hits 12709 12731 +22
- Misses 2864 2866 +2
+ Partials 1363 1361 -2
|
bowenlan-amzn
requested review from
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep and
AWSHurneyt
as code owners
AWSHurneyt
approved these changes
Oct 13, 2023
jowg-amazon
approved these changes
Oct 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 14, 2023
* Add more error notification at fail points * Handle exception gracefully * small fix --------- Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit a6a1f0c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
backport #1000
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.