Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #760 to 2.x #1002

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Backport #760 to 2.x #1002

merged 2 commits into from
Oct 12, 2023

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Oct 11, 2023 •
edited
Loading

Issue #, if available:

Description of changes:

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

tanqiuliu and others added 2 commits October 11, 2023 10:18
@tanqiuliu @bowenlan-amzn
@lezzago @AWSHurneyt @blampe @Hailong-am @sbcd90 @gaobinlong @DarshitChanpura
[Feature] Support Transform as an ISM action (opensearch-project#760)
f9e75c0 
* Initial impl

Signed-off-by: Tanqiu Liu <[email protected]>

* fix style

Signed-off-by: Tanqiu Liu <[email protected]>

* end to end functional

Signed-off-by: Tanqiu Liu <[email protected]>

* ISM transform unit tests & integ tests

Signed-off-by: Tanqiu Liu <[email protected]>

* Fix after core #8157 (opensearch-project#857)

Signed-off-by: bowenlan-amzn <[email protected]>

* Upgrade the backport workflow (opensearch-project#862)

Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* Added 2.9 release notes. (opensearch-project#851)

* Added 2.9 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.9 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.9 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* Handle NPE in isRollupIndex (opensearch-project#855)

* Handle NPE in isRollupIndex

`metadata.index()` can return `null`, so handle that case by returning
`false`.

Signed-off-by: Bryce Lampe <[email protected]>

* unit test

Signed-off-by: Bryce Lampe <[email protected]>

---------

Signed-off-by: Bryce Lampe <[email protected]>
Co-authored-by: bowenlan-amzn <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* Fix core XcontentType refactor (opensearch-project#873)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* fix for max & min aggregations when no metric property exist (opensearch-project#870)

Signed-off-by: Subhobrata Dey <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* core refactor change (opensearch-project#884)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* update backport branch name (opensearch-project#885)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* core refactor change (opensearch-project#887)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* Fix breaking change by core refactor (opensearch-project#888)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* fix core breaking (opensearch-project#906)

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* Support copy alias in rollover (opensearch-project#907)

* Support copy alias in rollover

Signed-off-by: bowenlan-amzn <[email protected]>

* 2.10

Signed-off-by: bowenlan-amzn <[email protected]>

---------

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* Set preference to _primary when searching control-center index (opensearch-project#911)

* Set preference to _primary when searching control-center index

Signed-off-by: gaobinlong <[email protected]>

* Use _primary_first instead

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* Add primary first preference to all search requests (opensearch-project#912)

Signed-off-by: Tanqiu Liu <[email protected]>

* fix intelliJ IDEA gradle sync error (opensearch-project#916)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* make control center index as system index (opensearch-project#919)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* Updates demo certs used in integ tests (opensearch-project#921)

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* Added 2.10 release notes (opensearch-project#925)

Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* Bump bwc version (opensearch-project#930)

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: Tanqiu Liu <[email protected]>

* fix integ tests; upgrade mappings versions

Signed-off-by: Tanqiu Liu <[email protected]>

* Fix DCO

Signed-off-by: Tanqiu Liu <[email protected]>

* Addressed pr comments; Add integ test case for re-execute the same transform action

Signed-off-by: Tanqiu Liu <[email protected]>

* Addressed detekt error

Signed-off-by: Tanqiu Liu <[email protected]>

* Added ISMTransform writeable test

Signed-off-by: Tanqiu Liu <[email protected]>

* Addressed comments; Moved updateTransformStartTime to IndexManagementRestTestCase

Signed-off-by: Tanqiu Liu <[email protected]>

---------

Signed-off-by: Tanqiu Liu <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Bryce Lampe <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Subhobrata Dey <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Co-authored-by: bowenlan-amzn <[email protected]>
Co-authored-by: Ashish Agrawal <[email protected]>
Co-authored-by: AWSHurneyt <[email protected]>
Co-authored-by: Bryce Lampe <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Co-authored-by: Subhobrata Dey <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
@bowenlan-amzn
[Test] increase the wait time after transform job triggered (opensear…
cb783ca 
…ch-project#999)

Signed-off-by: bowenlan-amzn <[email protected]>
@bowenlan-amzn bowenlan-amzn changed the title Ism transform action Backport #760 to 2.x Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #1002 (cb783ca) into 2.x (c20a502) will increase coverage by 0.05%.
The diff coverage is 80.80%.

@@             Coverage Diff              @@
##                2.x    #1002      +/-   ##
============================================
+ Coverage     74.94%   75.00%   +0.05%     
- Complexity     2835     2878      +43     
============================================
  Files           366      371       +5     
  Lines         16646    16936     +290     
  Branches       2413     2445      +32     
============================================
+ Hits          12475    12702     +227     
- Misses         2833     2876      +43     
- Partials       1338     1358      +20
Files Coverage Δ
...pensearch/indexmanagement/IndexManagementPlugin.kt 90.42% <100.00%> (ø)
...anagement/indexstatemanagement/ISMActionsParser.kt 91.93% <100.00%> (+0.13%) ⬆️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 69.14% <100.00%> (-1.92%) ⬇️
...exmanagement/opensearchapi/OpenSearchExtensions.kt 72.35% <100.00%> (-0.98%) ⬇️
...ent/indexstatemanagement/action/TransformAction.kt 70.00% <70.00%> (ø)
...dexstatemanagement/action/TransformActionParser.kt 57.14% <57.14%> (ø)
...ch/indexmanagement/transform/model/ISMTransform.kt 93.27% <93.27%> (ø)
...nt/step/transform/AttemptCreateTransformJobStep.kt 75.00% <75.00%> (ø)
...t/step/transform/WaitForTransformCompletionStep.kt 69.11% <69.11%> (ø)

... and 8 files with indirect coverage changes

@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review October 11, 2023 17:57
@bowenlan-amzn bowenlan-amzn added the v2.12.0 Issues targeting release v2.12.0 label Oct 11, 2023
@bowenlan-amzn bowenlan-amzn merged commit ef71c70 into opensearch-project:2.x Oct 12, 2023
22 of 23 checks passed
@bowenlan-amzn bowenlan-amzn deleted the ism_transform_action branch October 12, 2023 20:05
@sarthakaggarwal97 sarthakaggarwal97 mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jowg-amazon jowg-amazon jowg-amazon approved these changes

@AWSHurneyt AWSHurneyt AWSHurneyt approved these changes

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02

@lezzago lezzago Awaiting requested review from lezzago

@praveensameneni praveensameneni Awaiting requested review from praveensameneni

@xluo-aws xluo-aws Awaiting requested review from xluo-aws

@gaobinlong gaobinlong Awaiting requested review from gaobinlong

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@amsiglan amsiglan Awaiting requested review from amsiglan

@sbcd90 sbcd90 Awaiting requested review from sbcd90

@eirsep eirsep Awaiting requested review from eirsep

Assignees
No one assigned
Labels
v2.12.0 Issues targeting release v2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bowenlan-amzn @AWSHurneyt @jowg-amazon @tanqiuliu