[OSCI][Enhancement] lint checker for github actions #932
Conversation
Signed-off-by: kohinoor98 <[email protected]>
kohinoor98
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90 and
eirsep
as code owners
Signed-off-by: kohinoor98 <[email protected]>
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| branches: [main] |
There was a problem hiding this comment.
we may want to support 2.x branch also
There was a problem hiding this comment.
Hi @Hailong-am
Sure. Should I add this branch right now, or could it be a separate issue and a separate PR? Because once a branch is added, then ESLint errors in all files would need to be fixed, the test will always fail if this is not ensured.
There was a problem hiding this comment.
we may want to run lint check on changed/new files only.
There was a problem hiding this comment.
I am not sure we need this workflow, since it's already part of lint-stage which has to happen before commit. Unless someone disabled it in a PR, but reviewer should never let it happen
There was a problem hiding this comment.
Should we just close this PR as a similar code exists?
There was a problem hiding this comment.
Yes, we can close this one
kohinoor98
changed the title
Description
Added GitHub action workflow for checking lint errors using eslint
Important
This PR must be merged after #930 is merged into the codebase. Developers cannot commit code due to multiple lint issues already addressed in #930.
Issues Resolved
#86
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.