-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the unit tests #909
Conversation
Signed-off-by: bowenlan-amzn <[email protected]>
5ea2344
to
9027286
Compare
Codecov Report
@@ Coverage Diff @@
## main #909 +/- ##
========================================
Coverage 63.36% 63.36%
========================================
Files 341 341
Lines 11553 11553
Branches 2112 2243 +131
========================================
Hits 7321 7321
Misses 3658 3658
Partials 574 574 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems side effect from oui updates, approved. But could you please take a look on why cypress test failed?
@SuZhou-Joe create this issue #910, the aliases test seem flaky. Hopefully we can have OSCI participant to work on this? @AWSHurneyt one of the policies test keeps failing, cut issue #911, same here, better to have OSCI participant to help |
Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit 44abf1d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 44abf1d) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.