Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the unit tests #909

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Nov 1, 2023

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bowenlan-amzn <[email protected]>
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #909 (9027286) into main (b066a65) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main     #909    +/-   ##
========================================
  Coverage   63.36%   63.36%            
========================================
  Files         341      341            
  Lines       11553    11553            
  Branches     2112     2243   +131     
========================================
  Hits         7321     7321            
  Misses       3658     3658            
  Partials      574      574            

Copy link
Member

@SuZhou-Joe SuZhou-Joe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems side effect from oui updates, approved. But could you please take a look on why cypress test failed?

@bowenlan-amzn
Copy link
Member Author

@SuZhou-Joe create this issue #910, the aliases test seem flaky. Hopefully we can have OSCI participant to work on this?

@AWSHurneyt one of the policies test keeps failing, cut issue #911, same here, better to have OSCI participant to help

@bowenlan-amzn bowenlan-amzn merged commit 44abf1d into opensearch-project:main Nov 1, 2023
9 of 10 checks passed
@bowenlan-amzn bowenlan-amzn deleted the ut-update branch November 1, 2023 16:26
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 1, 2023
Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 44abf1d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bowenlan-amzn pushed a commit that referenced this pull request Nov 1, 2023
(cherry picked from commit 44abf1d)

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants