Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed repo name in snapshot flyout; Use schedule from policy during edit #824

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Fixed repo name in snapshot flyout; Use schedule from policy during edit #824

merged 1 commit into from
Jul 24, 2023

Conversation

amsiglan
Copy link
Contributor

Description

This PR fixes below issues:

  1. Snapshot flyout showing incorrect repository name
  2. When editing a snapshot policy, the schedule input gets populated with default values instead of the policy schedule details.

Issues Resolved

#823 , #822

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago
Copy link
Member

lezzago commented Jul 21, 2023

Can we get some unit test for this?

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #824 (0f93920) into main (9756dd5) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   63.38%   63.36%   -0.02%     
==========================================
  Files         341      341              
  Lines       11545    11553       +8     
  Branches     2108     2112       +4     
==========================================
+ Hits         7318     7321       +3     
- Misses       3654     3658       +4     
- Partials      573      574       +1

see 2 files with indirect coverage changes

bowenlan-amzn
bowenlan-amzn approved these changes Jul 22, 2023
View reviewed changes
public/pages/CreateSnapshotPolicy/components/CronSchedule/CronSchedule.tsx
@@ -55,6 +55,25 @@ const CronSchedule = ({
const [dayOfWeek, setWeek] = useState(initWeek);
const [dayOfMonth, setMonth] = useState(initMonth);

// When edit policy is clicked, during the initial render DEFAULT values get passed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The miss here is thought useState will re-create those values every time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

@amsiglan amsiglan merged commit 274d9bc into opensearch-project:main Jul 24, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2023
@github-actions
fixed repo name in snapshot flyout; schedule entry during ploicy edit (…
ac78c7e 
…#824)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 274d9bc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 24, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2023
@github-actions
fixed repo name in snapshot flyout; schedule entry during ploicy edit (…
81b7166 
…#824)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 274d9bc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 24, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2023
@github-actions
fixed repo name in snapshot flyout; schedule entry during ploicy edit (…
4a5f48e 
…#824)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 274d9bc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jul 24, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2023
@github-actions
fixed repo name in snapshot flyout; schedule entry during ploicy edit (…
ae0d0e2 
…#824)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 274d9bc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2023
@github-actions
fixed repo name in snapshot flyout; schedule entry during ploicy edit (…
4b3950b 
…#824)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 274d9bc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 24, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2023
@github-actions
fixed repo name in snapshot flyout; schedule entry during ploicy edit (…
2f1d41a 
…#824)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 274d9bc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 24, 2023
Merged
AWSHurneyt pushed a commit that referenced this pull request Jul 24, 2023
@opensearch-trigger-bot @github-actions
fixed repo name in snapshot flyout; schedule entry during ploicy edit (…
eeffd64 
…#824) (#827)

(cherry picked from commit 274d9bc)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Jul 24, 2023
@opensearch-trigger-bot @github-actions
fixed repo name in snapshot flyout; schedule entry during ploicy edit (…
53862cf 
…#824) (#828)

(cherry picked from commit 274d9bc)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Jul 24, 2023
@opensearch-trigger-bot @github-actions
fixed repo name in snapshot flyout; schedule entry during ploicy edit (…
c9fc758 
…#824) (#829)

(cherry picked from commit 274d9bc)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@andrross andrross mentioned this pull request Aug 23, 2023
Closed
bowenlan-amzn pushed a commit that referenced this pull request Sep 6, 2023
@opensearch-trigger-bot @github-actions
fixed repo name in snapshot flyout; schedule entry during ploicy edit (…
515e98d 
…#824) (#832)

(cherry picked from commit 274d9bc)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bowenlan-amzn pushed a commit that referenced this pull request Sep 6, 2023
@opensearch-trigger-bot @github-actions
fixed repo name in snapshot flyout; schedule entry during ploicy edit (…
5e25793 
…#824) (#830)

(cherry picked from commit 274d9bc)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bowenlan-amzn pushed a commit that referenced this pull request Sep 6, 2023
@opensearch-trigger-bot @github-actions
fixed repo name in snapshot flyout; schedule entry during ploicy edit (…
a2bdf5e 
…#824) (#831)

(cherry picked from commit 274d9bc)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@bowenlan-amzn bowenlan-amzn mentioned this pull request Sep 22, 2023
Closed
@toby181 toby181 mentioned this pull request Jan 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenlan-amzn bowenlan-amzn bowenlan-amzn approved these changes

@getsaurabh02 getsaurabh02 getsaurabh02 approved these changes

@AWSHurneyt AWSHurneyt Awaiting requested review from AWSHurneyt

@praveensameneni praveensameneni Awaiting requested review from praveensameneni

@xluo-aws xluo-aws Awaiting requested review from xluo-aws

@gaobinlong gaobinlong Awaiting requested review from gaobinlong

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.5 backport 2.6 backport 2.7 backport 2.8 backport 2.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amsiglan @lezzago @getsaurabh02 @bowenlan-amzn