Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] fix: add validation on data.method when using transport.request #803

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 13fb97f from #801

@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-801-to-2.x branch from f593e29 to db05f7d Compare July 5, 2023 03:20
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #803 (db05f7d) into 2.x (c1299d1) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head db05f7d differs from pull request most recent head 26b2ea6. Consider uploading reports for the commit 26b2ea6 to get more accurate results

@@            Coverage Diff             @@
##              2.x     #803      +/-   ##
==========================================
- Coverage   63.40%   63.40%   -0.01%     
==========================================
  Files         340      340              
  Lines       11541    11540       -1     
  Branches     2239     2238       -1     
==========================================
- Hits         7318     7317       -1     
  Misses       3649     3649              
  Partials      574      574              

see 1 file with indirect coverage changes

* fix: add validation on data.method when using tranport.request

Signed-off-by: SuZhoue-Joe <[email protected]>

* feat: add validation on endpoint

Signed-off-by: SuZhoue-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhoue-Joe <[email protected]>

* feat: add more protect

Signed-off-by: SuZhoue-Joe <[email protected]>

---------

Signed-off-by: SuZhoue-Joe <[email protected]>
(cherry picked from commit 13fb97f)
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-801-to-2.x branch from db05f7d to 26b2ea6 Compare July 5, 2023 03:21
@SuZhou-Joe SuZhou-Joe requested a review from Hailong-am July 5, 2023 07:04
@Hailong-am Hailong-am merged commit 0d4cf81 into 2.x Jul 10, 2023
@github-actions github-actions bot deleted the backport/backport-801-to-2.x branch July 10, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants