Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.7.0 #702

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Bump version to 2.7.0 #702

merged 2 commits into from
Apr 12, 2023

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Apr 12, 2023

Description

Bump version to 2.7.0

Issues Resolved

#691

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Zelin Hao <[email protected]>
@zelinh zelinh requested a review from a team April 12, 2023 19:49
@zelinh zelinh self-assigned this Apr 12, 2023
bowenlan-amzn
bowenlan-amzn previously approved these changes Apr 12, 2023
OPENSEARCH_DASHBOARDS_VERSION: '2.6'
OPENSEARCH_VERSION: '2.6.0-SNAPSHOT'
OPENSEARCH_DASHBOARDS_VERSION: '2.7'
OPENSEARCH_VERSION: '2.7.0-SNAPSHOT'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to remove this, and line 36 will be ./gradlew run &

@@ -7,8 +7,8 @@ on:
branches:
- "*"
env:
OPENSEARCH_DASHBOARDS_VERSION: '2.6'
OPENSEARCH_VERSION: '2.6.0-SNAPSHOT'
OPENSEARCH_DASHBOARDS_VERSION: '2.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 2.x
And on line 32: ref: ${{ env.OPENSEARCH_DASHBOARDS_VERSION }}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks @bowenlan-amzn

Signed-off-by: Zelin Hao <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #702 (a10b821) into 2.x (9c9b5f0) will not change coverage.
The diff coverage is n/a.

❗ Current head a10b821 differs from pull request most recent head 09f22cb. Consider uploading reports for the commit 09f22cb to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              2.x     #702   +/-   ##
=======================================
  Coverage   58.97%   58.97%           
=======================================
  Files         296      296           
  Lines        9806     9806           
  Branches     1826     1826           
=======================================
  Hits         5783     5783           
  Misses       3572     3572           
  Partials      451      451           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zelinh
Copy link
Member Author

zelinh commented Apr 12, 2023

@opensearch-project/index-management Can we have another approval for this PR for we could unblock the 2.7.0 OSD build. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants