Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes for v2.5 #559

Merged
merged 10 commits into from
Jan 11, 2023

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Jan 10, 2023

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe SuZhou-Joe requested a review from a team January 10, 2023 10:20
gaobinlong
gaobinlong previously approved these changes Jan 10, 2023
Copy link
Contributor

@gaobinlong gaobinlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Hailong-am
Hailong-am previously approved these changes Jan 10, 2023
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Hailong-am
Copy link
Collaborator

please fix the failed E2E test

@SuZhou-Joe SuZhou-Joe dismissed stale reviews from Hailong-am and gaobinlong via ca83655 January 11, 2023 00:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Merging #559 (6d9a07d) into 2.x (f860818) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x     #559      +/-   ##
==========================================
- Coverage   59.77%   59.74%   -0.03%     
==========================================
  Files         268      268              
  Lines        8860     8871      +11     
  Branches     1613     1618       +5     
==========================================
+ Hits         5296     5300       +4     
- Misses       3173     3177       +4     
- Partials      391      394       +3     
Impacted Files Coverage Δ
...lic/pages/Aliases/containers/CreateAlias/index.tsx 76.78% <0.00%> (-2.85%) ⬇️
...CreateIndex/components/IndexDetail/IndexDetail.tsx 76.62% <0.00%> (-2.05%) ⬇️
...plate/containers/TemplateDetail/TemplateDetail.tsx 87.50% <0.00%> (-1.60%) ⬇️
...s/containers/DeleteAliasModal/DeleteAliasModal.tsx 86.95% <0.00%> (ø)
...s/components/DeleteIndexModal/DeleteIndexModal.tsx 100.00% <0.00%> (ø)
...emplate/components/IndexSettings/IndexSettings.tsx 83.33% <0.00%> (+3.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: suzhou <[email protected]>
@SuZhou-Joe SuZhou-Joe merged commit 06959cf into opensearch-project:2.x Jan 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2023
* feat: some ui changes

Signed-off-by: suzhou <[email protected]>

* feat: update system index/alias wording

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

* feat: add judgement

Signed-off-by: suzhou <[email protected]>

* feat: fix template stuff

Signed-off-by: suzhou <[email protected]>

* feat: update snapshot

Signed-off-by: suzhou <[email protected]>

* feat: update placeholder

Signed-off-by: suzhou <[email protected]>

* feat: use 2.5 version

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

Signed-off-by: suzhou <[email protected]>
(cherry picked from commit 06959cf)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2023
* feat: some ui changes

Signed-off-by: suzhou <[email protected]>

* feat: update system index/alias wording

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

* feat: add judgement

Signed-off-by: suzhou <[email protected]>

* feat: fix template stuff

Signed-off-by: suzhou <[email protected]>

* feat: update snapshot

Signed-off-by: suzhou <[email protected]>

* feat: update placeholder

Signed-off-by: suzhou <[email protected]>

* feat: use 2.5 version

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

Signed-off-by: suzhou <[email protected]>
(cherry picked from commit 06959cf)
SuZhou-Joe added a commit that referenced this pull request Jan 11, 2023
* feat: some ui changes

Signed-off-by: suzhou <[email protected]>

* feat: update system index/alias wording

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

* feat: add judgement

Signed-off-by: suzhou <[email protected]>

* feat: fix template stuff

Signed-off-by: suzhou <[email protected]>

* feat: update snapshot

Signed-off-by: suzhou <[email protected]>

* feat: update placeholder

Signed-off-by: suzhou <[email protected]>

* feat: use 2.5 version

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

Signed-off-by: suzhou <[email protected]>
(cherry picked from commit 06959cf)

Co-authored-by: suzhou <[email protected]>
SuZhou-Joe added a commit that referenced this pull request Jan 11, 2023
* feat: some ui changes

Signed-off-by: suzhou <[email protected]>

* feat: update system index/alias wording

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

* feat: add judgement

Signed-off-by: suzhou <[email protected]>

* feat: fix template stuff

Signed-off-by: suzhou <[email protected]>

* feat: update snapshot

Signed-off-by: suzhou <[email protected]>

* feat: update placeholder

Signed-off-by: suzhou <[email protected]>

* feat: use 2.5 version

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

Signed-off-by: suzhou <[email protected]>
(cherry picked from commit 06959cf)

Co-authored-by: suzhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants