Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix mac platform error #518

Merged

Conversation

SuZhou-Joe
Copy link
Member

Signed-off-by: suzhou [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe SuZhou-Joe requested a review from a team January 3, 2023 06:19
@codecov-commenter
Copy link

Codecov Report

Merging #518 (a84ab28) into main (0b6457f) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   49.79%   49.67%   -0.13%     
==========================================
  Files         193      195       +2     
  Lines        6203     6225      +22     
  Branches      975     1023      +48     
==========================================
+ Hits         3089     3092       +3     
- Misses       2891     2910      +19     
  Partials      223      223              
Impacted Files Coverage Δ
...s/components/ApplyPolicyModal/ApplyPolicyModal.tsx 48.45% <0.00%> (-0.51%) ⬇️
...ex-management-dashboards-plugin/utils/constants.ts 100.00% <0.00%> (ø)
...ndex-management-dashboards-plugin/public/plugin.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 147090b into opensearch-project:main Jan 3, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 3, 2023
Signed-off-by: suzhou <[email protected]>

Signed-off-by: suzhou <[email protected]>
(cherry picked from commit 147090b)
SuZhou-Joe added a commit that referenced this pull request Jan 3, 2023
Signed-off-by: suzhou <[email protected]>

Signed-off-by: suzhou <[email protected]>
(cherry picked from commit 147090b)

Co-authored-by: suzhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants