Add shrink index page #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Binlong Gao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## index-operation-common #516 +/- ##
==========================================================
+ Coverage 52.21% 53.32% +1.10%
==========================================================
Files 219 222 +3
Lines 6885 7078 +193
Branches 1160 1198 +38
==========================================================
+ Hits 3595 3774 +179
- Misses 3023 3030 +7
- Partials 267 274 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
amsiglan
reviewed
Jan 8, 2023
| if (result && result.ok) { | ||
| this.context.notifications.toasts.addSuccess(`${indexName} has been set to block write operations.`); | ||
| } else { | ||
| const errorMessage = `There is a problem set index setting for ${indexName}, please check with Admin`; |
There was a problem hiding this comment.
There seems to be some typo here
There is a problem set index setting for. Should it be There is a problem when updating index setting for...
There was a problem hiding this comment.
Yeah, thanks for your review, I'll change it and check the whole file.
amsiglan
approved these changes
Jan 8, 2023
|
closed by #537 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Binlong Gao [email protected]
Description
The main changes of this PR are:
Issues Resolved
#468
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.