Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge alias management to index-operation-common #510

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Dec 23, 2022

Signed-off-by: suzhou [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: suzhou <[email protected]>
@SuZhou-Joe SuZhou-Joe requested a review from a team December 23, 2022 07:11
@SuZhou-Joe SuZhou-Joe added v2.5.0 'Issues and PRs related to version v2.5.0' index-operation labels Dec 23, 2022
@SuZhou-Joe SuZhou-Joe self-assigned this Dec 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #510 (e457cc8) into index-operation-common (f3fb5d9) will increase coverage by 1.21%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##           index-operation-common     #510      +/-   ##
==========================================================
+ Coverage                   52.21%   53.43%   +1.21%     
==========================================================
  Files                         219      226       +7     
  Lines                        6885     7099     +214     
  Branches                     1160     1202      +42     
==========================================================
+ Hits                         3595     3793     +198     
- Misses                       3023     3029       +6     
- Partials                      267      277      +10     
Impacted Files Coverage Δ
...lic/pages/Aliases/containers/CreateAlias/index.tsx 78.18% <0.00%> (ø)
...ublic/pages/Aliases/containers/Aliases/Aliases.tsx 91.91% <0.00%> (ø)
...Aliases/components/IndexControls/IndexControls.tsx 100.00% <0.00%> (ø)
...ds-plugin/public/pages/Aliases/utils/constants.tsx 100.00% <0.00%> (ø)
...c/pages/CreateIndex/containers/IndexForm/index.tsx 80.00% <0.00%> (ø)
...s/containers/DeleteAliasModal/DeleteAliasModal.tsx 90.47% <0.00%> (ø)
...ic/pages/Aliases/containers/AliasActions/index.tsx 100.00% <0.00%> (ø)
...ement-dashboards-plugin/public/pages/Main/Main.tsx 8.77% <0.00%> (+1.36%) ⬆️
...ic/components/ContentPanel/ContentPanelActions.tsx 100.00% <0.00%> (+11.11%) ⬆️
...s-plugin/public/components/BetterToolTip/index.tsx 87.50% <0.00%> (+12.50%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

xluo-aws
xluo-aws previously approved these changes Dec 24, 2022
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
@amsiglan
Copy link
Contributor

amsiglan commented Jan 8, 2023

Fix the snapshot failure. Rest looks good

@xluo-aws xluo-aws mentioned this pull request Jan 10, 2023
1 task
@SuZhou-Joe SuZhou-Joe closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
index-operation v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants