Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge common components and services to 2.x #508

Closed
wants to merge 1 commit into from

Conversation

SuZhou-Joe
Copy link
Member

  • feat: split to common change

Signed-off-by: suzhou [email protected]

  • feat: update

Signed-off-by: suzhou [email protected]

Signed-off-by: suzhou [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* feat: split to common change

Signed-off-by: suzhou <[email protected]>

* feat: update

Signed-off-by: suzhou <[email protected]>

Signed-off-by: suzhou <[email protected]>
@SuZhou-Joe SuZhou-Joe requested a review from a team December 23, 2022 06:46
@codecov-commenter
Copy link

Codecov Report

Merging #508 (f3fb5d9) into 2.x (423db21) will increase coverage by 2.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x     #508      +/-   ##
==========================================
+ Coverage   49.67%   52.21%   +2.54%     
==========================================
  Files         195      219      +24     
  Lines        6225     6885     +660     
  Branches      975     1160     +185     
==========================================
+ Hits         3092     3595     +503     
- Misses       2910     3023     +113     
- Partials      223      267      +44     
Impacted Files Coverage Δ
...ashboards-plugin/public/components/Modal/Modal.tsx 51.11% <0.00%> (-30.71%) ⬇️
...ic/components/ContentPanel/ContentPanelActions.tsx 88.88% <0.00%> (-11.12%) ⬇️
...-dashboards-plugin/public/index_management_app.tsx 6.25% <0.00%> (-0.42%) ⬇️
...ndex-management-dashboards-plugin/public/plugin.ts 0.00% <0.00%> (ø)
...ex-management-dashboards-plugin/utils/constants.ts 100.00% <0.00%> (ø)
...gement-dashboards-plugin/public/utils/constants.ts 100.00% <0.00%> (ø)
...ment-dashboards-plugin/public/JobHandler/index.tsx 23.75% <0.00%> (ø)
...-plugin/public/components/BetterComboBox/index.tsx 16.66% <0.00%> (ø)
...ards-plugin/public/context/JobSchedulerContext.tsx 0.00% <0.00%> (ø)
...c/components/SwitchableEditor/SwitchableEditor.tsx 90.90% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@SuZhou-Joe SuZhou-Joe self-assigned this Dec 23, 2022
@SuZhou-Joe SuZhou-Joe added v2.5.0 'Issues and PRs related to version v2.5.0' index-operation labels Dec 23, 2022
@amsiglan
Copy link
Contributor

amsiglan commented Jan 8, 2023

Please break down this PR into smaller PRs. It is difficult to review these many files

@xluo-aws xluo-aws mentioned this pull request Jan 10, 2023
1 task
@SuZhou-Joe SuZhou-Joe closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
index-operation v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants