-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge common components and services to 2.x #508
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: split to common change Signed-off-by: suzhou <[email protected]> * feat: update Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #508 +/- ##
==========================================
+ Coverage 49.67% 52.21% +2.54%
==========================================
Files 195 219 +24
Lines 6225 6885 +660
Branches 975 1160 +185
==========================================
+ Hits 3092 3595 +503
- Misses 2910 3023 +113
- Partials 223 267 +44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
SuZhou-Joe
added
v2.5.0
'Issues and PRs related to version v2.5.0'
index-operation
labels
Dec 23, 2022
amsiglan
reviewed
Jan 8, 2023
amsiglan
reviewed
Jan 8, 2023
amsiglan
reviewed
Jan 8, 2023
amsiglan
reviewed
Jan 8, 2023
amsiglan
reviewed
Jan 8, 2023
amsiglan
reviewed
Jan 8, 2023
Please break down this PR into smaller PRs. It is difficult to review these many files |
amsiglan
reviewed
Jan 8, 2023
amsiglan
reviewed
Jan 8, 2023
amsiglan
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: suzhou [email protected]
Signed-off-by: suzhou [email protected]
Signed-off-by: suzhou [email protected]
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.