Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shrinkIndexFlyout to page #476

Merged

Conversation

gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Dec 19, 2022

Description

The main changes of this PR are:

  1. Change shrinkIndexFlyout to page.
  2. Add unit tests for the shrink index page.
  3. Modify some error message or warning message.

Issues Resolved

#468

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
@gaobinlong gaobinlong requested a review from a team December 19, 2022 04:08
@codecov-commenter
Copy link

Codecov Report

Merging #476 (9729a2f) into index-operation (9e9f03c) will increase coverage by 0.03%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           index-operation     #476      +/-   ##
===================================================
+ Coverage            60.65%   60.69%   +0.03%     
===================================================
  Files                  250      250              
  Lines                 8301     8360      +59     
  Branches              1465     1477      +12     
===================================================
+ Hits                  5035     5074      +39     
- Misses                2914     2929      +15     
- Partials               352      357       +5     
Impacted Files Coverage Δ
.../pages/Indices/containers/IndicesActions/index.tsx 72.89% <0.00%> (-3.58%) ⬇️
...ement-dashboards-plugin/public/pages/Main/Main.tsx 6.32% <0.00%> (-0.17%) ⬇️
...gement-dashboards-plugin/public/utils/constants.ts 100.00% <0.00%> (ø)
...components/ShrinkIndexFlyout/ShrinkIndexFlyout.tsx
.../Indices/components/ShrinkIndexFlyout/constants.ts
...plugin/public/pages/ShrinkIndex/utils/constants.ts 100.00% <0.00%> (ø)
.../ShrinkIndex/container/ShrinkIndex/ShrinkIndex.tsx 88.12% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

title="The source index's health status is Red, please check its status before shrinking."
color="danger"
iconType="alert"
></EuiCallOut>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about this message The index is currently in the Red health state and may be running operations in the background. Wait until the index becomes Green to continue shrinking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But there are many reasons why the index is Red, like a node was left from the cluster and has not been back, or one primary shard's segment files are corrupted, so running operations maybe not a common reason, I think. Thanks for your advice, I'will think over the wording.

@gaobinlong gaobinlong merged commit a36ab02 into opensearch-project:index-operation Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants