-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change shrinkIndexFlyout to page #476
Change shrinkIndexFlyout to page #476
Conversation
Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## index-operation #476 +/- ##
===================================================
+ Coverage 60.65% 60.69% +0.03%
===================================================
Files 250 250
Lines 8301 8360 +59
Branches 1465 1477 +12
===================================================
+ Hits 5035 5074 +39
- Misses 2914 2929 +15
- Partials 352 357 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
title="The source index's health status is Red, please check its status before shrinking." | ||
color="danger" | ||
iconType="alert" | ||
></EuiCallOut> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about this message The index is currently in the Red health state and may be running operations in the background. Wait until the index becomes Green to continue shrinking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But there are many reasons why the index is Red, like a node was left from the cluster and has not been back, or one primary shard's segment files are corrupted, so running operations maybe not a common reason, I think. Thanks for your advice, I'will think over the wording.
Description
The main changes of this PR are:
Issues Resolved
#468
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.