Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] [1.3] Add windows os for unit tests #436

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ed48832 from #435

* added windows os support

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* use bash shell for running commands

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed yaml

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* modified test command

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed test issues

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit ed48832)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team December 5, 2022 23:50
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #436 (8fb57ba) into 1.x (10ba1af) will increase coverage by 13.70%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              1.x     #436       +/-   ##
===========================================
+ Coverage   49.78%   63.48%   +13.70%     
===========================================
  Files         154      153        -1     
  Lines        4335     4431       +96     
  Branches      665      696       +31     
===========================================
+ Hits         2158     2813      +655     
+ Misses       2018     1402      -616     
- Partials      159      216       +57     
Impacted Files Coverage Δ
...-plugin/public/pages/CreateRollup/utils/helpers.ts 68.29% <0.00%> (-9.13%) ⬇️
...lCreatePolicy/components/Transition/Transition.tsx 28.88% <0.00%> (-1.12%) ⬇️
...ntainers/VisualCreatePolicy/VisualCreatePolicy.tsx 12.50% <0.00%> (-0.78%) ⬇️
...gement-dashboards-plugin/public/utils/constants.ts 100.00% <0.00%> (ø)
...ement-dashboards-plugin/public/pages/Main/Main.tsx 10.00% <0.00%> (ø)
...ment-dashboards-plugin/public/services/Services.ts 100.00% <0.00%> (ø)
...-dashboards-plugin/public/index_management_app.tsx 7.69% <0.00%> (ø)
...-dashboards-plugin/public/services/IndexService.ts 67.56% <0.00%> (ø)
...dashboards-plugin/public/services/PolicyService.ts 100.00% <0.00%> (ø)
...dashboards-plugin/public/services/RollupService.ts 100.00% <0.00%> (ø)
... and 145 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amsiglan
Copy link
Contributor

amsiglan commented Dec 6, 2022

Fixes #431

@amsiglan amsiglan merged commit e2df055 into 1.x Dec 6, 2022
@github-actions github-actions bot deleted the backport/backport-435-to-1.x branch December 6, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants