Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replica parameter and shard number option list #406

Merged

Conversation

xluo-aws
Copy link
Member

Signed-off-by: Xuesong Luo [email protected]

Description

[Add replica as optional parameter to split index; Provide valid shard number options for user to choose from]

Issues Resolved

[List any issues this PR will resolve https://github.com//issues/393]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Xuesong Luo <[email protected]>
@xluo-aws xluo-aws requested a review from a team November 27, 2022 06:40
@xluo-aws xluo-aws changed the title Remove console log Add replica parameter and shard number option list Nov 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2022

Codecov Report

Merging #406 (73e247e) into index-operation (8c61ffb) will increase coverage by 0.11%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           index-operation     #406      +/-   ##
===================================================
+ Coverage            57.57%   57.69%   +0.11%     
===================================================
  Files                  222      222              
  Lines                 7331     7358      +27     
  Branches              1188     1192       +4     
===================================================
+ Hits                  4221     4245      +24     
+ Misses                2810     2809       -1     
- Partials               300      304       +4     
Impacted Files Coverage Δ
...onents/FormGenerator/built_in_components/index.tsx 71.42% <0.00%> (-8.58%) ⬇️
...pages/CreateIndex/components/AliasSelect/index.tsx 89.74% <0.00%> (-5.13%) ⬇️
...s/components/SplitIndexFlyout/SplitIndexFlyout.tsx 93.24% <0.00%> (+7.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

SuZhou-Joe
SuZhou-Joe previously approved these changes Nov 28, 2022
Hailong-am
Hailong-am previously approved these changes Nov 28, 2022
…ot be selected automatically.

Signed-off-by: Xuesong Luo <[email protected]>
@Hailong-am Hailong-am merged commit 110fd06 into opensearch-project:index-operation Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants