Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test case for reindex #404

Merged

Conversation

Hailong-am
Copy link
Collaborator

Description

  1. add integration test for create new index in reindex flow
  2. add more unit test
  3. add writing index check for alias

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

2. add more unit test

Signed-off-by: Hailong Cui <[email protected]>
@Hailong-am Hailong-am requested a review from a team November 25, 2022 03:28
@Hailong-am Hailong-am marked this pull request as draft November 25, 2022 05:20
Signed-off-by: Hailong Cui <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #404 (0b77833) into index-operation (8c61ffb) will increase coverage by 0.11%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           index-operation     #404      +/-   ##
===================================================
+ Coverage            57.57%   57.68%   +0.11%     
===================================================
  Files                  222      222              
  Lines                 7331     7341      +10     
  Branches              1188     1191       +3     
===================================================
+ Hits                  4221     4235      +14     
+ Misses                2810     2807       -3     
+ Partials               300      299       -1     
Impacted Files Coverage Δ
...public/pages/Reindex/container/Reindex/Reindex.tsx 86.63% <0.00%> (+1.88%) ⬆️
...-dashboards-plugin/public/services/IndexService.ts 70.00% <0.00%> (+5.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Hailong-am Hailong-am marked this pull request as ready for review November 28, 2022 05:41
@gaobinlong gaobinlong self-requested a review November 28, 2022 06:15
@Hailong-am Hailong-am merged commit 6c2c2be into opensearch-project:index-operation Nov 28, 2022
@Hailong-am Hailong-am deleted the index-operation branch November 28, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants