bump loader-utils to 1.4.1 to address vulnerability alert, specify OSD 2.4.0 #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]> Currently only visually functional. TODO - make it apply the options Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]> Split radio buttons into SnapshotRestoreOption and SnapshotRenameOptions Signed-off-by: Chris Hesterman <[email protected]> Move 'restore' button between 'delete' and 'take snapshot' Signed-off-by: Chris Hesterman <[email protected]> Set default rename option to 'add prefix' Signed-off-by: Chris Hesterman <[email protected]>
…ions Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]> Implement first 4 Advanced restore options functionality Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]> Passing tests for create repo and create snapshot Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
…ards-plugin Signed-off-by: Chris Hesterman <[email protected]>
…ards-plugin Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
…ards-plugin Signed-off-by: Chris Hesterman <[email protected]>
…ards-plugin Signed-off-by: Chris Hesterman <[email protected]>
…ards-plugin Signed-off-by: Chris Hesterman <[email protected]>
…ards-plugin Signed-off-by: Chris Hesterman <[email protected]>
…ards-plugin Signed-off-by: Chris Hesterman <[email protected]>
…ards-plugin Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
…ards-plugin Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Signed-off-by: Chris Hesterman <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #381 +/- ##
=======================================
Coverage 49.79% 49.79%
=======================================
Files 193 193
Lines 6203 6203
Branches 975 975
=======================================
Hits 3089 3089
Misses 2891 2891
Partials 223 223 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Could you mention in the PR description that this PR also adjusts the OSD version used by the cypress and unit test workflows? |
AWSHurneyt
approved these changes
Nov 21, 2022
|
Yes! |
phestecAMZN
changed the title
Angie-Zhang
approved these changes
Nov 21, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 21, 2022
…D 2.4.0 (#381) * Change alignment of Snapshot Management panels in pages/Main/Main.tsx Signed-off-by: Chris Hesterman <[email protected]> * Unify vertical button alignment across panels, ContentPanel.tsx Signed-off-by: Chris Hesterman <[email protected]> * Update jest snapshots, add ROUTE_STYLE variable Signed-off-by: Chris Hesterman <[email protected]> * Add placeholder restore button to Snapshots panel Signed-off-by: Chris Hesterman <[email protected]> * Comment out line 20 rollups_spec.js in cypress/integration/ Signed-off-by: Chris Hesterman <[email protected]> * Remove unused code and comment cypress/integration/rollups_spec.js Signed-off-by: Chris Hesterman <[email protected]> * Starting adaptation/use of existing code for Restore functionality Signed-off-by: Chris Hesterman <[email protected]> * Adapt Snapshots.tsx to include RestoreSnapshotFlyout Signed-off-by: Chris Hesterman <[email protected]> * Add restoreSnapshot method to SMservice,RestoreSnapshotResponse int Signed-off-by: Chris Hesterman <[email protected]> * Implement RestoreSnapshotFlyout open/close Signed-off-by: Chris Hesterman <[email protected]> * Make Snapshot name appear on RestoreSnapshotFlyout Signed-off-by: Chris Hesterman <[email protected]> * Add/adapt restoreSnapshot to server/SnapshotManagementService Signed-off-by: Chris Hesterman <[email protected]> * Add route for restoreSnapshot in server/routes.ts Signed-off-by: Chris Hesterman <[email protected]> * Rudimentary restore from snapshot functionality reached, buggy Signed-off-by: Chris Hesterman <[email protected]> * Fix index list-snapshot restore, restrict restore to single selection Signed-off-by: Chris Hesterman <[email protected]> * Remove console.logs, commented out code Signed-off-by: Chris Hesterman <[email protected]> * Create Advanced options accordion for Snapshot restore. Signed-off-by: Chris Hesterman <[email protected]> Currently only visually functional. TODO - make it apply the options Signed-off-by: Chris Hesterman <[email protected]> * Add initial restore/rename options to ui. Only visual functionality Signed-off-by: Chris Hesterman <[email protected]> * Resolve radio button events not firing Signed-off-by: Chris Hesterman <[email protected]> Split radio buttons into SnapshotRestoreOption and SnapshotRenameOptions Signed-off-by: Chris Hesterman <[email protected]> Move 'restore' button between 'delete' and 'take snapshot' Signed-off-by: Chris Hesterman <[email protected]> Set default rename option to 'add prefix' Signed-off-by: Chris Hesterman <[email protected]> * Add AddPrefixInput, remove unused component RestoreSnapshotInitialOptions Signed-off-by: Chris Hesterman <[email protected]> * Fix issues with restore specific indices Signed-off-by: Chris Hesterman <[email protected]> Implement first 4 Advanced restore options functionality Signed-off-by: Chris Hesterman <[email protected]> * Begin cypress testing for snapshots Signed-off-by: Chris Hesterman <[email protected]> Passing tests for create repo and create snapshot Signed-off-by: Chris Hesterman <[email protected]> * Begin cypress testing Snapshots. Create repo and Create snapshot done Signed-off-by: Chris Hesterman <[email protected]> * Implement add_prefix functionality for snapshot restore Signed-off-by: Chris Hesterman <[email protected]> * Implement rename indices option for restore snapshot Signed-off-by: Chris Hesterman <[email protected]> * Remove console.logs, unusted variables in SnapshotFlyout, SMservice Signed-off-by: Chris Hesterman <[email protected]> * Add full stop to help text/errors, add RESTORE_OPTIONS enum Signed-off-by: Chris Hesterman <[email protected]> * Add back line 20 in rollups_spec, required by changes in 2.3 release. Signed-off-by: Chris Hesterman <[email protected]> * Remove unused getRepos func, add repo prop, trim state in RestoreFlyout Signed-off-by: Chris Hesterman <[email protected]> * Add increment to 2.3.0 Signed-off-by: Chris Hesterman <[email protected]> * Version bump 2.3.0 to 2.3 1 Signed-off-by: Chris Hesterman <[email protected]> * Add version bump 2.3.1 for OS in cypress-workflow.yml Signed-off-by: Chris Hesterman <[email protected]> * Remove 2.3.1 bump Signed-off-by: Chris Hesterman <[email protected]> * Change 2.4 to 2.4.0 opensearch_dashboards.json Signed-off-by: Chris Hesterman <[email protected]> * Update package.json, opensearch-dashboards.json Signed-off-by: Chris Hesterman <[email protected]> * Update package.json, opensearch_dashboards.json Signed-off-by: Chris Hesterman <[email protected]> * Update OSD to 2.4.1, update loader-utils, ts-loader, webpack Signed-off-by: Chris Hesterman <[email protected]> * Update loader-utils to 1.4.1 Signed-off-by: Chris Hesterman <[email protected]> * Roll back to 2.4.0 OSD Signed-off-by: Chris Hesterman <[email protected]> Signed-off-by: Chris Hesterman <[email protected]> (cherry picked from commit d7e6849)
phestecAMZN
added a commit
that referenced
this pull request
Nov 29, 2022
…D 2.4.0 (#381) (#387) * Change alignment of Snapshot Management panels in pages/Main/Main.tsx Signed-off-by: Chris Hesterman <[email protected]> * Unify vertical button alignment across panels, ContentPanel.tsx Signed-off-by: Chris Hesterman <[email protected]> * Update jest snapshots, add ROUTE_STYLE variable Signed-off-by: Chris Hesterman <[email protected]> * Add placeholder restore button to Snapshots panel Signed-off-by: Chris Hesterman <[email protected]> * Comment out line 20 rollups_spec.js in cypress/integration/ Signed-off-by: Chris Hesterman <[email protected]> * Remove unused code and comment cypress/integration/rollups_spec.js Signed-off-by: Chris Hesterman <[email protected]> * Starting adaptation/use of existing code for Restore functionality Signed-off-by: Chris Hesterman <[email protected]> * Adapt Snapshots.tsx to include RestoreSnapshotFlyout Signed-off-by: Chris Hesterman <[email protected]> * Add restoreSnapshot method to SMservice,RestoreSnapshotResponse int Signed-off-by: Chris Hesterman <[email protected]> * Implement RestoreSnapshotFlyout open/close Signed-off-by: Chris Hesterman <[email protected]> * Make Snapshot name appear on RestoreSnapshotFlyout Signed-off-by: Chris Hesterman <[email protected]> * Add/adapt restoreSnapshot to server/SnapshotManagementService Signed-off-by: Chris Hesterman <[email protected]> * Add route for restoreSnapshot in server/routes.ts Signed-off-by: Chris Hesterman <[email protected]> * Rudimentary restore from snapshot functionality reached, buggy Signed-off-by: Chris Hesterman <[email protected]> * Fix index list-snapshot restore, restrict restore to single selection Signed-off-by: Chris Hesterman <[email protected]> * Remove console.logs, commented out code Signed-off-by: Chris Hesterman <[email protected]> * Create Advanced options accordion for Snapshot restore. Signed-off-by: Chris Hesterman <[email protected]> Currently only visually functional. TODO - make it apply the options Signed-off-by: Chris Hesterman <[email protected]> * Add initial restore/rename options to ui. Only visual functionality Signed-off-by: Chris Hesterman <[email protected]> * Resolve radio button events not firing Signed-off-by: Chris Hesterman <[email protected]> Split radio buttons into SnapshotRestoreOption and SnapshotRenameOptions Signed-off-by: Chris Hesterman <[email protected]> Move 'restore' button between 'delete' and 'take snapshot' Signed-off-by: Chris Hesterman <[email protected]> Set default rename option to 'add prefix' Signed-off-by: Chris Hesterman <[email protected]> * Add AddPrefixInput, remove unused component RestoreSnapshotInitialOptions Signed-off-by: Chris Hesterman <[email protected]> * Fix issues with restore specific indices Signed-off-by: Chris Hesterman <[email protected]> Implement first 4 Advanced restore options functionality Signed-off-by: Chris Hesterman <[email protected]> * Begin cypress testing for snapshots Signed-off-by: Chris Hesterman <[email protected]> Passing tests for create repo and create snapshot Signed-off-by: Chris Hesterman <[email protected]> * Begin cypress testing Snapshots. Create repo and Create snapshot done Signed-off-by: Chris Hesterman <[email protected]> * Implement add_prefix functionality for snapshot restore Signed-off-by: Chris Hesterman <[email protected]> * Implement rename indices option for restore snapshot Signed-off-by: Chris Hesterman <[email protected]> * Remove console.logs, unusted variables in SnapshotFlyout, SMservice Signed-off-by: Chris Hesterman <[email protected]> * Add full stop to help text/errors, add RESTORE_OPTIONS enum Signed-off-by: Chris Hesterman <[email protected]> * Add back line 20 in rollups_spec, required by changes in 2.3 release. Signed-off-by: Chris Hesterman <[email protected]> * Remove unused getRepos func, add repo prop, trim state in RestoreFlyout Signed-off-by: Chris Hesterman <[email protected]> * Add increment to 2.3.0 Signed-off-by: Chris Hesterman <[email protected]> * Version bump 2.3.0 to 2.3 1 Signed-off-by: Chris Hesterman <[email protected]> * Add version bump 2.3.1 for OS in cypress-workflow.yml Signed-off-by: Chris Hesterman <[email protected]> * Remove 2.3.1 bump Signed-off-by: Chris Hesterman <[email protected]> * Change 2.4 to 2.4.0 opensearch_dashboards.json Signed-off-by: Chris Hesterman <[email protected]> * Update package.json, opensearch-dashboards.json Signed-off-by: Chris Hesterman <[email protected]> * Update package.json, opensearch_dashboards.json Signed-off-by: Chris Hesterman <[email protected]> * Update OSD to 2.4.1, update loader-utils, ts-loader, webpack Signed-off-by: Chris Hesterman <[email protected]> * Update loader-utils to 1.4.1 Signed-off-by: Chris Hesterman <[email protected]> * Roll back to 2.4.0 OSD Signed-off-by: Chris Hesterman <[email protected]> Signed-off-by: Chris Hesterman <[email protected]> (cherry picked from commit d7e6849) Co-authored-by: Chris Hesterman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses vulnerability around loader-utils 1.4.0.
Explicitly specify OSD version 2.4.0 vs. 2.4.1 or 2.4 until OpenSearch version bumped to 2.4.1, as tests would fail when looking for OS 2.4.1
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.