Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor for spirint1 #375

Merged

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Nov 12, 2022

Signed-off-by: suzhou [email protected]

Description

  1. Fix issues for first spirint demo.
  2. Fix selection bug when refresh indices table.
  3. Fix the loop refresh bug in IndexDetail components

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: suzhou <[email protected]>
@SuZhou-Joe SuZhou-Joe requested a review from a team November 12, 2022 04:02
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Merging #375 (dada7bb) into index-operation (7e717cf) will increase coverage by 0.36%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           index-operation     #375      +/-   ##
===================================================
+ Coverage            56.48%   56.85%   +0.36%     
===================================================
  Files                  213      215       +2     
  Lines                 6956     7011      +55     
  Branches              1121     1127       +6     
===================================================
+ Hits                  3929     3986      +57     
  Misses                2741     2741              
+ Partials               286      284       -2     
Impacted Files Coverage Δ
...ublic/pages/Indices/containers/Indices/Indices.tsx 80.55% <0.00%> (-2.06%) ⬇️
.../pages/Indices/containers/IndicesActions/index.tsx 70.64% <0.00%> (-1.59%) ⬇️
...onents/FormGenerator/built_in_components/index.tsx 75.00% <0.00%> (ø)
...ugin/public/components/EuiToolTipWrapper/index.tsx 100.00% <0.00%> (ø)
...c/pages/CreateIndex/containers/IndexForm/index.tsx 90.07% <0.00%> (ø)
...eateIndex/components/IndexMapping/IndexMapping.tsx 93.02% <0.00%> (+0.16%) ⬆️
...CreateIndex/components/IndexDetail/IndexDetail.tsx 92.85% <0.00%> (+1.81%) ⬆️
...lic/pages/Indices/containers/IndexDetail/index.tsx 84.31% <0.00%> (+4.31%) ⬆️
...pages/CreateIndex/components/AliasSelect/index.tsx 95.23% <0.00%> (+4.76%) ⬆️
...CreateIndex/containers/CreateIndex/CreateIndex.tsx 100.00% <0.00%> (+11.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit e93d5f9 into opensearch-project:index-operation Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants