Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change help text in "RestoreSnapshotAdvancedSettings" , documentation url in "IndexSettingsInput" #365

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Change help text in "RestoreSnapshotAdvancedSettings" , documentation url in "IndexSettingsInput" #365

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7dfec03
Change help text - ignore unavailable indices
phestecAMZN Nov 9, 2022
6f0c671
Update ext link, IndexSettingsInput to ref 'Dynamic Index Settings' docs
phestecAMZN Nov 9, 2022
ea19594
Change url back to Static and Dynamic docs link
phestecAMZN Nov 9, 2022
3fa9891
Change link in IndexSettingsInput to general "Index Settings" docs
phestecAMZN Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions public/pages/Snapshots/components/IndexSettingsInput/IndexSettingsInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import { EuiFormRow, EuiText, EuiTextArea, EuiSpacer, EuiLink } from "@elastic/eui";
import React, { useState, ChangeEvent } from "react";
import { RESTORE_SNAPSHOT_DOCUMENTATION_URL } from "../../../../utils/constants"
import { INDEX_SETTINGS_URL } from "../../../../utils/constants"

interface IndexSettingsInputProps {
getIndexSettings: (indexSettings: string, ignore: boolean) => void;
Expand Down Expand Up @@ -38,7 +38,7 @@ const IndexSettingsInput = ({ getIndexSettings, ignore, showError, inputError }:
<EuiText size="xs" style={{ padding: "0px 0px 5px 0px" }}>
<p style={{ fontWeight: 200 }}>
{`${helperText} `}
<EuiLink href={RESTORE_SNAPSHOT_DOCUMENTATION_URL} target="_blank" external={true} rel="noopener noreferrer">
<EuiLink href={INDEX_SETTINGS_URL} target="_blank" external={true} rel="noopener noreferrer">
Learn more
</EuiLink>
</p>
Expand Down
2 changes: 1 addition & 1 deletion ...es/Snapshots/components/SnapshotRestoreAdvancedOptions/SnapshotRestoreAdvancedOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const SnapshotRestoreAdvancedOptions = ({
label={
<CheckBoxLabel
title="Ignore unavailable indices"
helpText="Instead of failing snapshot, ignore any indexes that are unavailable or do not exist."
helpText="Instead of failing restore operation, ignore any indices that are unavailable or do not exist."
/>
}
checked={ignoreUnavailable}
Expand Down
2 changes: 1 addition & 1 deletion public/utils/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const ACTIONS_DOCUMENTATION_URL = "https://opensearch.org/docs/im-plugin/
export const STATES_DOCUMENTATION_URL = "https://opensearch.org/docs/im-plugin/ism/policies/#states";
export const ERROR_NOTIFICATION_DOCUMENTATION_URL = "https://opensearch.org/docs/im-plugin/ism/policies/#error-notifications";
export const TRANSITION_DOCUMENTATION_URL = "https://opensearch.org/docs/im-plugin/ism/policies/#transitions";

export const INDEX_SETTINGS_URL = "https://opensearch.org/docs/latest/api-reference/index-apis/create-index/#dynamic-index-settings";
export const SNAPSHOT_MANAGEMENT_DOCUMENTATION_URL = "https://opensearch.org/docs/latest/opensearch/snapshots/snapshot-management/";
export const CRON_EXPRESSION_DOCUMENTATION_URL = "https://opensearch.org/docs/latest/monitoring-plugins/alerting/cron/";
export const RESTORE_SNAPSHOT_DOCUMENTATION_URL =
Expand Down