-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete snapshot restore, mvp for 2.4 #315
Changes from all commits
ede3cb1
a5fa7fb
6145593
f86a83f
7a5545c
8001349
f27c4e4
cf0917a
391159f
983ed48
3558936
b3141bd
7bfdb86
845cca2
703d93b
78095b7
e16528b
75e1dfe
02d651c
bf4a4a5
e8e46ea
5cd9afc
a80656f
aa46d71
3cf3711
b9ad019
fdfb43a
5af4208
5cf239f
934a27d
81f99d7
3ebe37a
6045bba
b3a0936
88bef4b
15f41a4
366e5a5
70d56c8
6a8a56c
2637b33
5e46117
a08c1b4
327d7da
fd77a64
9caf86b
efc525c
0a7f6ee
c752956
988c9ef
f35c282
cc8afc6
1053f95
fb7f19e
f553dbe
628e431
09f57a8
350f31a
92d38f4
0532b0e
653fc0d
5f4f5b5
21f2bfc
b185b41
6d0a58b
44297f3
4f4e5d6
ccca9bb
127f6c1
7ef5272
e01c130
0a78884
9956737
655b796
f862840
02009be
824c70f
e397187
1f1786e
2dba9dc
e248600
28ee07a
6d0ebd1
0761ce1
df492c5
a331d19
e910c48
8c71551
a7fa503
12d08d0
f8cd7b8
20cad41
af281e6
7b794d4
9a436a9
e4e4193
0b3c47d
d373b51
db1eb7d
96890ae
018b5dd
8cf3fbd
1c3b254
bd60f93
45577c7
9a7dd20
6936c8c
5267c34
b178d96
aed60fa
b04d870
2ba8b71
b2f9132
98cc0ee
9315502
6609e8d
f856c19
db5918e
20e8c9e
762c60d
d741039
71bd131
c13a1d0
d1a5a84
86e9c85
fb0d869
8cef14d
c3022a3
eeff511
b03da8a
4fdab67
88f6441
8604d0a
eecb5fc
78040eb
f729c39
bad73ce
ce07b21
72fe9d3
5e9722b
f2301d1
6582ad5
1b7d215
b61ccec
20288f6
cbbdce4
522cb27
acf0644
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
import { EuiModal, EuiText, EuiButton, EuiModalHeader, EuiModalFooter, EuiModalBody, EuiModalHeaderTitle } from "@elastic/eui"; | ||
import React from "react"; | ||
|
||
|
||
interface ErrorModalProps { | ||
error: React.ErrorInfo; | ||
onClick: (e: React.MouseEvent<HTMLButtonElement>) => void; | ||
} | ||
|
||
const ErrorModal = ({ onClick, error }: ErrorModalProps) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is an existing way of showing modal in this repo. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will do when time allows. |
||
|
||
return ( | ||
<> | ||
<EuiModal onClose={onClick}> | ||
<EuiModalHeader color="danger" style={{ flexDirection: "column", alignItems: "flex-start" }}> | ||
<EuiModalHeaderTitle><h1>{error.type}</h1></EuiModalHeaderTitle> | ||
</EuiModalHeader> | ||
|
||
<EuiModalBody> | ||
<EuiText size="m" color="danger">{error.reason}.</EuiText> | ||
</EuiModalBody> | ||
|
||
<EuiModalFooter> | ||
<EuiButton onClick={onClick} fill>Close</EuiButton> | ||
</EuiModalFooter> | ||
</EuiModal> | ||
</> | ||
); | ||
}; | ||
|
||
export default ErrorModal; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
import ErrorModal from "./ErrorModal"; | ||
|
||
export default ErrorModal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Seems to a general interface, consider rename as ErrorToastMessage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I created this specifically for Restore errors per UX request to have specific functionality. How about RestoreErrorToastMessage ? there are at least 4 common errors that can happen during restore