Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rel to link for external links, IM dashboards plugin #261

Merged
merged 13 commits into from
Oct 3, 2022
Merged

Add rel to link for external links, IM dashboards plugin #261

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ede3cb1
Change alignment of Snapshot Management panels in pages/Main/Main.tsx
phestecAMZN Aug 24, 2022
a5fa7fb
Unify vertical button alignment across panels, ContentPanel.tsx
phestecAMZN Aug 24, 2022
6145593
Update jest snapshots, add ROUTE_STYLE variable
phestecAMZN Aug 24, 2022
f86a83f
Add placeholder restore button to Snapshots panel
phestecAMZN Aug 24, 2022
7a5545c
Merge branch 'opensearch-project:main' into main
phestecAMZN Aug 26, 2022
8001349
Comment out line 20 rollups_spec.js in cypress/integration/
phestecAMZN Aug 26, 2022
f27c4e4
Remove unused code and comment cypress/integration/rollups_spec.js
phestecAMZN Aug 26, 2022
cf0917a
Merge branch 'opensearch-project:main' into main
phestecAMZN Sep 1, 2022
4199a14
Set window.opener to null via anchor tag 'rel' attribute-TransformInd…
phestecAMZN Sep 15, 2022
024de14
Add rel="noopener noreferrer" to external links, update snapshots
phestecAMZN Sep 15, 2022
dedb5cf
Merge branch 'opensearch-project:main' into add_rel_to_link
phestecAMZN Sep 15, 2022
3f8cbb6
Include version increment to 2.3.0
phestecAMZN Sep 15, 2022
a088bee
Remove 2.3 version bump
phestecAMZN Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cypress-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ on:
branches:
- "*"
env:
OPENSEARCH_DASHBOARDS_VERSION: '2.2'
OPENSEARCH_VERSION: '2.2.1-SNAPSHOT'
OPENSEARCH_DASHBOARDS_VERSION: '2.3'
OPENSEARCH_VERSION: '2.3.0-SNAPSHOT'
jobs:
tests:
name: Run Cypress E2E tests
Expand Down
14 changes: 9 additions & 5 deletions opensearch_dashboards.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
{
"id": "indexManagementDashboards",
"version": "2.2.1.0",
"opensearchDashboardsVersion": "2.2.1",
"configPath": ["opensearch_index_management"],
"requiredPlugins": ["navigation"],
"version": "2.3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the version bump from this PR and then add a backport PR from 2.x to main for this PR. This way this PR can be backported to other branches like 2.x without issues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, on it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"opensearchDashboardsVersion": "2.3.0",
"configPath": [
"opensearch_index_management"
],
"requiredPlugins": [
"navigation"
],
"server": true,
"ui": true
}
}
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "opensearch_index_management_dashboards",
"version": "2.2.1.0",
"version": "2.3.0.0",
"description": "Opensearch Dashboards plugin for Index Management",
"main": "index.js",
"license": "Apache-2.0",
Expand Down Expand Up @@ -64,4 +64,4 @@
"engines": {
"yarn": "^1.21.1"
}
}
}
2 changes: 1 addition & 1 deletion public/pages/ChangePolicy/components/NewPolicy/NewPolicy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export default class NewPolicy extends React.Component<NewPolicyProps, NewPolicy
<EuiText size="xs">
<p>
When the new policy will take effect depends on the current state of indices and the states of the new policy.{" "}
<EuiLink href={DOCUMENTATION_URL} target="_blank">
<EuiLink href={DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more <EuiIcon type="popout" size="s" />
</EuiLink>
</p>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/CreatePolicy/components/DefinePolicy/DefinePolicy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const DefinePolicy = ({ jsonString, onChange, onAutoIndent, hasJSONError }: Defi
<p>
You can think of policies as state machines. "Actions" are the operations ISM performs when an index is in a certain state.
"Transitions" define when to move from one state to another.{" "}
<EuiLink href={DOCUMENTATION_URL} target="_blank">
<EuiLink href={DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more <EuiIcon type="popout" size="s" />
</EuiLink>
</p>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/CreatePolicy/containers/CreatePolicy/CreatePolicy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export default class CreatePolicy extends Component<CreatePolicyProps, CreatePol
This ensures that any update to a policy doesn't harm indices that are running under an older version of the policy. To carry
over your edits to these indices, please use the "Change Policy" under "Managed Indices" to reapply the policy after submitting
your edits.{" "}
<EuiLink href={DOCUMENTATION_URL} target="_blank">
<EuiLink href={DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more <EuiIcon type="popout" size="s" />
</EuiLink>
</p>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/CreateRollup/components/RollupIndices/RollupIndices.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export default class RollupIndices extends Component<RollupIndicesProps, RollupI
"The target index stores rollup results. You can select an existing index or type in a new index name with embedded variables "
}
{
<EuiLink external href={ROLLUP_RESULTS_HELP_TEXT_LINK} target={"_blank"}>
<EuiLink external href={ROLLUP_RESULTS_HELP_TEXT_LINK} target={"_blank"} rel="noopener noreferrer">
Learn more
</EuiLink>
}
Expand Down
2 changes: 1 addition & 1 deletion public/pages/CreateSnapshotPolicy/components/CronSchedule/CronSchedule.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ const CronSchedule = ({
<EuiText color="subdued" size="s" style={{ padding: "5px 0px" }}>
<p style={{ fontWeight: 200, fontSize: "12px" }}>
Use Cron expression to define complex schedule.{" "}
<EuiLink href={CRON_EXPRESSION_DOCUMENTATION_URL} target="_blank">
<EuiLink href={CRON_EXPRESSION_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more
</EuiLink>
</p>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/CreateSnapshotPolicy/containers/CreateSnapshotPolicy/CreateSnapshotPolicy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ export default class CreateSnapshotPolicy extends Component<CreateSMPolicyProps,
<EuiText color="subdued" size="s" style={{ padding: "5px 0px" }}>
<p style={{ fontWeight: 200 }}>
Snapshot policies allow you to define an automated snapshot schedule and retention period.{" "}
<EuiLink href={SNAPSHOT_MANAGEMENT_DOCUMENTATION_URL} target="_blank">
<EuiLink href={SNAPSHOT_MANAGEMENT_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more
</EuiLink>
</p>
Expand Down
7 changes: 6 additions & 1 deletion public/pages/CreateTransform/components/TransformIndices/TransformIndices.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,12 @@ export default class TransformIndices extends Component<TransformIndicesProps, T
</EuiText>

<EuiText size="xs">
<EuiLink external={true} target="_blank" href="https://opensearch.org/docs/opensearch/query-dsl/index/">
<EuiLink
external={true}
target="_blank"
href="https://opensearch.org/docs/opensearch/query-dsl/index/"
rel="noopener noreferrer"
>
{" "}
Learn more
</EuiLink>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/Indices/components/ApplyPolicyModal/ApplyPolicyModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ export default class ApplyPolicyModal extends Component<ApplyPolicyModalProps, A
<EuiText size="xs" grow={false}>
<p>
This policy includes a rollover action. Specify a rollover alias.{" "}
<EuiLink href={DOCUMENTATION_URL} target="_blank">
<EuiLink href={DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more <EuiIcon type="popout" size="s" />
</EuiLink>
</p>
Expand Down
8 changes: 4 additions & 4 deletions public/pages/Repositories/components/CreateRepositoryFlyout/CreateRepositoryFlyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export default class CreateRepositoryFlyout extends Component<CreateRepositoryPr
<EuiText color="subdued" size="xs" style={{ padding: "5px 0px" }}>
<p style={{ fontWeight: 200 }}>
Define a repository by custom type and settings.{" "}
<EuiLink href={S3_REPOSITORY_DOCUMENTATION_URL} target="_blank">
<EuiLink href={S3_REPOSITORY_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
View sample configurations
</EuiLink>
</p>
Expand Down Expand Up @@ -186,7 +186,7 @@ export default class CreateRepositoryFlyout extends Component<CreateRepositoryPr
<EuiText color="subdued" size="xs" style={{ padding: "5px 0px" }}>
<p style={{ fontWeight: 200 }}>
Define additional settings for this repository.{" "}
<EuiLink href={FS_REPOSITORY_DOCUMENTATION_URL} target="_blank">
<EuiLink href={FS_REPOSITORY_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more
</EuiLink>
</p>
Expand All @@ -212,7 +212,7 @@ export default class CreateRepositoryFlyout extends Component<CreateRepositoryPr
<p>
To use a custom repository, such as Amazon S3, Azure Blob Storage or similar, install and configure the respective repository
plugin on OpenSearch and then define the repository configuration below.{" "}
<EuiLink href={REPOSITORY_DOCUMENTATION_URL} target="_blank">
<EuiLink href={REPOSITORY_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more
</EuiLink>
</p>
Expand Down Expand Up @@ -240,7 +240,7 @@ export default class CreateRepositoryFlyout extends Component<CreateRepositoryPr
<EuiText color="subdued" size="xs" style={{ padding: "5px 0px" }}>
<p style={{ fontWeight: 200 }}>
Select a supported repository type. For additional types, install the latest repository plugins and choose Custom configuration.{" "}
<EuiLink href={REPOSITORY_DOCUMENTATION_URL} target="_blank">
<EuiLink href={REPOSITORY_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more
</EuiLink>
</p>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/SnapshotPolicies/containers/SnapshotPolicies/SnapshotPolicies.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ export default class SnapshotPolicies extends Component<SnapshotPoliciesProps, S
<EuiText color="subdued" size="s" style={{ padding: "5px 0px" }}>
<p style={{ fontWeight: 200 }}>
Define an automated snapshot schedule and retention period with a snapshot policy.{" "}
<EuiLink href={SNAPSHOT_MANAGEMENT_DOCUMENTATION_URL} target="_blank">
<EuiLink href={SNAPSHOT_MANAGEMENT_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more
</EuiLink>
</p>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/Snapshots/containers/Snapshots/Snapshots.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ export default class Snapshots extends Component<SnapshotsProps, SnapshotsState>
<p style={{ fontWeight: 200 }}>
Snapshots are taken automatically from snapshot policies, or you can initiate manual snapshots to save to a repository. <br />
To restore a snapshot, use the snapshot restore API.{" "}
<EuiLink href={RESTORE_SNAPSHOT_DOCUMENTATION_URL} target="_blank">
<EuiLink href={RESTORE_SNAPSHOT_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more
</EuiLink>
</p>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/VisualCreatePolicy/components/ISMTemplates/ISMTemplates.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const ISMTemplates = ({ policy, onChangePolicy }: ISMTemplatesProps) => {
<EuiText color="subdued" size="s" style={{ padding: "5px 0px" }}>
<p style={{ fontWeight: 200 }}>
Specify ISM template patterns that match the index to apply the policy.{" "}
<EuiLink href={DOCUMENTATION_URL} target="_blank">
<EuiLink href={DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more <EuiIcon type="popout" size="s" />
</EuiLink>
</p>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/VisualCreatePolicy/components/States/States.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const States = ({ onOpenFlyout, policy, onClickEditState, onClickDeleteState, on
You can think of policies as state machines. "Actions" are the operations ISM performs when an index is in a certain state.
<br />
"Transitions" define when to move from one state to another.{" "}
<EuiLink href={STATES_DOCUMENTATION_URL} target="_blank">
<EuiLink href={STATES_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more <EuiIcon type="popout" size="s" />
</EuiLink>
</p>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/VisualCreatePolicy/components/Transition/Transition.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ const Transition = ({ uiTransition, onChangeTransition }: TransitionProps) => {
title="Cron expression"
helpText="The matching cron expression required to transition to the next state."
learnMore={
<EuiLink href={TRANSITION_DOCUMENTATION_URL} target="_blank">
<EuiLink href={TRANSITION_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more <EuiIcon type="popout" size="s" />
</EuiLink>
}
Expand Down
2 changes: 1 addition & 1 deletion public/pages/VisualCreatePolicy/containers/CreateAction/CreateAction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export default class CreateAction extends Component<CreateActionProps, CreateAct

<EuiText size="xs" style={{ fontWeight: 200 }}>
Actions are the operations ISM performs when an index is in a certain state.{" "}
<EuiLink href={ACTIONS_DOCUMENTATION_URL} target="_blank">
<EuiLink href={ACTIONS_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more <EuiIcon type="popout" size="s" />
</EuiLink>
</EuiText>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/VisualCreatePolicy/containers/CreateTransition/CreateTransition.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export default class CreateTransition extends Component<CreateTransitionProps, C
<EuiText size="xs" style={{ fontWeight: 200 }}>
Transitions define the conditions that need to be met for a state to change. After all actions in the current state are
completed, the policy starts checking the conditions for transitions.{" "}
<EuiLink href={TRANSITION_DOCUMENTATION_URL} target="_blank">
<EuiLink href={TRANSITION_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more <EuiIcon type="popout" size="s" />
</EuiLink>
</EuiText>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/VisualCreatePolicy/containers/ErrorNotification/ErrorNotification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export default class ErrorNotification extends Component<ErrorNotificationProps,
<EuiText color="subdued" size="s" style={{ padding: "5px 0px" }}>
<p style={{ fontWeight: 200 }}>
You can set up an error notification for when a policy execution fails.{" "}
<EuiLink href={ERROR_NOTIFICATION_DOCUMENTATION_URL} target="_blank">
<EuiLink href={ERROR_NOTIFICATION_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more <EuiIcon type="popout" size="s" />
</EuiLink>
</p>
Expand Down
2 changes: 1 addition & 1 deletion public/pages/VisualCreatePolicy/containers/VisualCreatePolicy/VisualCreatePolicy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ export default class VisualCreatePolicy extends Component<VisualCreatePolicyProp
<EuiText size="s">
<p>
Policies let you automatically perform administrative operations on indices.{" "}
<EuiLink href={POLICY_DOCUMENTATION_URL} target="_blank">
<EuiLink href={POLICY_DOCUMENTATION_URL} target="_blank" rel="noopener noreferrer">
Learn more <EuiIcon type="popout" size="s" />
</EuiLink>
</p>
Expand Down