Introducing transforms #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move duplicate code to base class for Edit and Create Rollup pages.
Hide type for fields Fetch 50 sample data
* Refactored UX based on feedback and to better align with mockups. * Refactored UX based on feedback and to better align with mockups.
…anged display condition for warning message. (#173) * Refactored UX based on feedback and to better align with mockups. * Refactored UX based on feedback and to better align with mockups. * Removed cron expression schedule option, reformatted popovers, and changed display condition for warning message. * Implemented inline error for duplicate job names.
* Decouple preview transform table from define transform * Decouple EmptyPrompt * Some code cleanup * Add plus button * Update PreviewEmptyPrompt.tsx * Have dummy context menu showing up * Update transform options menu text * Able to add histogram using new menu * Add histogramPanel component * Add date histogram panel * Update TranformOptions.tsx * Update date histogram options * Simplify popover actions * Percentile panel * Percentile panel * Remove transformation in preview initial commit * Correcting the name of file TransformOptions * Show preview table with temporary aggList * Remove transformation * clean up code * Update DefineTransforms.tsx * Hide pagination in preview table * Clean up code Co-authored-by: Eric Lobdell <[email protected]>
* Update Schedule component title size * Add isReadOnly prop to tables * Update preview table to support details page * Update ReviewDefinition.tsx
* Review aggregate and group on Create Transform now matches mock * Schedule page formatting changes and updated helpText * Adjusted further Schedule page spacing per QA meeting
…r displaying error messages. (#178) * Refactored UX based on feedback and to better align with mockups. * Refactored UX based on feedback and to better align with mockups. * Removed cron expression schedule option, reformatted popovers, and changed display condition for warning message. * Implemented inline error for duplicate job names. * Refactored transform job status icons, and implemented error modal for displaying error messages. * Rephrased the warning message displayed in step 4, and the toast displayed upon transform creation. * Adding spacer between accordion button and accordion body contents.
* Update Index filter popover text and clear aggList when source index is changed * Clean up code and add helptext to preview table * Modify target field name for histogram * Parse date histogram render in step 2 tables
…s, resized accordion titles, and some other cleanup. (#181) * Refactored UX based on feedback and to better align with mockups. * Refactored UX based on feedback and to better align with mockups. * Removed cron expression schedule option, reformatted popovers, and changed display condition for warning message. * Implemented inline error for duplicate job names. * Refactored transform job status icons, and implemented error modal for displaying error messages. * Rephrased the warning message displayed in step 4, and the toast displayed upon transform creation. * Adding spacer between accordion button and accordion body contents. * Refactored padding around tables, wrapped job names in quotation marks, resized accordion titles, and some other cleanup.
* Fixed change source index warning conditional and added padding * Updated aggregations check to use aggList and added right side padding * Further adjusted right side warning padding
…aces, updated function to delete DSQ property (#182)
* Update Index filter popover text and clear aggList when source index is changed * Clean up code and add helptext to preview table * Modify target field name for histogram * Parse date histogram render in step 2 tables * Add horizontal scroll to define transform table and remove highlight when is readonly * Remove highlight on preview table when is read-only * Add horizontal scroll to preview table * Show all preview columns by default * Modify delete icon * Truncate field text * Truncate text on preview columns * Add tooltip to column headers * Add tooltip to readonly tables * Update DefineTransforms.tsx
Signed-off-by: Ravi Thaluru <[email protected]>
Signed-off-by: Ravi Thaluru <[email protected]>
Signed-off-by: Ravi Thaluru <[email protected]>
Signed-off-by: Ravi Thaluru <[email protected]>
lezzago
reviewed
May 25, 2021
| import DefineTransforms from "../../components/DefineTransforms"; | ||
| import { FieldItem, TransformAggItem, TransformGroupItem } from "../../../../../models/interfaces"; | ||
|
|
||
| interface CreateTransformStep2Props extends RouteComponentProps { |
There was a problem hiding this comment.
Prefer better naming to describe the purpose of the step. The same goes with other classes with similar naming
There was a problem hiding this comment.
makes sense, will address this in the next PR
Comment on lines
+333
to
+338
| //debug use | ||
| console.log("From: " + from + " size: " + size); | ||
| const { callAsCurrentUser: callWithRequest } = this.esDriver.asScoped(request); | ||
| const searchResponse: SearchResponse<any> = await callWithRequest("search", params); | ||
| //debug use | ||
| // console.log("Server search response: " + JSON.stringify(searchResponse)); |
There was a problem hiding this comment.
Do we want to keep the debug console logs? If so, we should have the second one uncommented.
There was a problem hiding this comment.
Debug logs are not required, will have another PR to clean this up.
lezzago
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Introducing transforms
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.