Bug fixes and retracting some formatting changes #1141

tandonks · 2024-08-21T12:41:38Z

Description

Fixed some bugs in ISM dashboard pages, added MDS support in shrink page in Indexes, some changes for yarn file and retracting some of the Look Good Feel Good code change done in the last PR

Issues Resolved

[List any issues this PR will resolve]

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kshitij Tandon <[email protected]>

public/pages/Aliases/components/IndexControls/IndexControls.tsx

public/pages/Indices/components/IndexControls/IndexControls.tsx

public/pages/ManagedIndices/components/ManagedIndexControls/ManagedIndexControls.tsx

AMoo-Miki · 2024-08-21T16:56:12Z

public/pages/Reindex/container/Reindex/Reindex.tsx

            fullWidth
-            helpText="Specify one or more indexes or data streams you want to reindex from."
+            label=""
+            helpText={
+              <div>
+                Use reindex to make extensive changes to your index. Reindex will copy data of the source index into another index.{" "}
+                <EuiLink href={this.context.docLinks.links.opensearch.reindexData.base} target="_blank" rel="noopener noreferrer">
+                  Learn more
+                </EuiLink>
+              </div>
+            }


Is this a description? If so, please use TopNavControlDescriptionData. The one used, TopNavControlComponentData, is for extremely rare situations where existing controls don't provide what you need. All other types of TopNavControlData get globally styled but TopNavControlComponentData by their nature cannot and are hence tough to maintain for you.

Hi Miki, we actually tried that but the EUI link which we were getting looked a bit too spaced out hence did this. PFA the screenshots:
With current code:

With the suggested code:

Please let us know if we are fine with the UI or know a fix to remove the spaces. In that case we need to update all the description in ISM that we can take up as follow up PR

I have edited it as per your suggestion but would be great if you could clarify it once. Thanks!

public/pages/Reindex/container/Reindex/Reindex.tsx

public/pages/ShrinkIndex/container/ShrinkIndex/ShrinkIndex.test.tsx

public/pages/ShrinkIndex/container/ShrinkIndex/ShrinkIndex.tsx

AMoo-Miki · 2024-08-21T17:02:05Z

public/pages/ShrinkIndex/container/ShrinkIndex/ShrinkIndex.tsx

+
+        {Common()}
+      </div>
+    ) : (
      <div style={{ padding: "0px 50px" }}>


We should find a way to get rid of these unstandard stylings. @kgcreative

public/pages/SplitIndex/container/SplitIndex/SplitIndex.tsx

public/pages/Indices/containers/Indices/Indices.tsx

public/pages/Indices/containers/IndicesActions/index.tsx

public/pages/ManagedIndices/containers/ManagedIndices/ManagedIndices.tsx

public/pages/Templates/containers/Templates/Templates.tsx

public/pages/Transforms/utils/metadataHelper.tsx

Signed-off-by: Kshitij Tandon <[email protected]>

CaptainDredge

LGTM, we can merge after all Miki's suggestions have been addressed

Signed-off-by: Kshitij Tandon <[email protected]>

opensearch-trigger-bot · 2024-08-22T14:54:08Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1141-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ccdfcd3fbb37a30e3f6afde0243b0d15ff2de7b5
# Push it to GitHub
git push --set-upstream origin backport/backport-1141-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1141-to-2.x.

…1141) * A couple of bug fixes and Look Good Feel Good changes Signed-off-by: Kshitij Tandon <[email protected]> * Revert yarn.lock changes Signed-off-by: Kshitij Tandon <[email protected]> * Bug fix in Indexes page and worked on comments on previous commit Signed-off-by: Kshitij Tandon <[email protected]> * Add yarn file Signed-off-by: Kshitij Tandon <[email protected]> * Removing feel good changes from prior commit Signed-off-by: Kshitij Tandon <[email protected]> * Fixed rerendering of pages on clicking change and create buttons Signed-off-by: Kshitij Tandon <[email protected]> * Adding MDS support in Shrink page in Indexes in ISM Signed-off-by: Kshitij Tandon <[email protected]> * Fixed a test file and removed couple of reduntant flag uses Signed-off-by: Kshitij Tandon <[email protected]> * Some more frivolous code from last commit Signed-off-by: Kshitij Tandon <[email protected]> * Some snap file changes Signed-off-by: Kshitij Tandon <[email protected]> * Resolved comments Signed-off-by: Kshitij Tandon <[email protected]> * Import issue in Templates Signed-off-by: Kshitij Tandon <[email protected]> * Description changes Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]>

* A couple of bug fixes and Look Good Feel Good changes * Revert yarn.lock changes * Bug fix in Indexes page and worked on comments on previous commit * Add yarn file * Removing feel good changes from prior commit * Fixed rerendering of pages on clicking change and create buttons * Adding MDS support in Shrink page in Indexes in ISM * Fixed a test file and removed couple of reduntant flag uses * Some more frivolous code from last commit * Some snap file changes * Resolved comments * Import issue in Templates * Description changes --------- Signed-off-by: Kshitij Tandon <[email protected]>

tandonks added 9 commits August 21, 2024 15:55

A couple of bug fixes and Look Good Feel Good changes

0c72485

Signed-off-by: Kshitij Tandon <[email protected]>

Revert yarn.lock changes

1dc3c9a

Signed-off-by: Kshitij Tandon <[email protected]>

Bug fix in Indexes page and worked on comments on previous commit

de5a794

Signed-off-by: Kshitij Tandon <[email protected]>

Add yarn file

a054dce

Signed-off-by: Kshitij Tandon <[email protected]>

Removing feel good changes from prior commit

2f2381c

Signed-off-by: Kshitij Tandon <[email protected]>

Fixed rerendering of pages on clicking change and create buttons

021c676

Signed-off-by: Kshitij Tandon <[email protected]>

Adding MDS support in Shrink page in Indexes in ISM

0d2f19a

Signed-off-by: Kshitij Tandon <[email protected]>

Fixed a test file and removed couple of reduntant flag uses

93c2f96

Signed-off-by: Kshitij Tandon <[email protected]>

Some more frivolous code from last commit

1e794ad

Signed-off-by: Kshitij Tandon <[email protected]>

tandonks requested review from amsiglan, AWSHurneyt, bowenlan-amzn, getsaurabh02, praveensameneni, xluo-aws, gaobinlong, Hailong-am, SuZhou-Joe, lezzago, sbcd90, eirsep, r1walz and vikasvb90 as code owners August 21, 2024 12:41

Some snap file changes

ed67afc

Signed-off-by: Kshitij Tandon <[email protected]>