Bug fixes for Policy Managed Indices and Indexes pages #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
tandonks
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
SuZhou-Joe
reviewed
Aug 20, 2024
| @@ -435,7 +435,7 @@ export class ManagedIndices extends MDSEnabledComponent<ManagedIndicesProps, Man | |||
| showEditModal, | |||
| isPopoverOpen, | |||
| } = this.state; | |||
|
|
|||
| console.log(this.context); | |||
SuZhou-Joe
reviewed
Aug 20, 2024
Comment on lines
+544
to
+561
| <ModalConsumer> | ||
| {({ onShow, onClose }) => ( | ||
| <EuiContextMenuItem | ||
| key="Edit" | ||
| toolTipPosition="left" | ||
| disabled={selectedItems.length !== 1 || isDataStreamIndexSelected} | ||
| data-test-subj="editOption" | ||
| onClick={() => | ||
| onShow(RolloverAliasModal, { | ||
| index: selectedItems[0].index, | ||
| core: this.context, | ||
| }) | ||
| } | ||
| > | ||
| Edit rollover alias | ||
| </EuiContextMenuItem> | ||
| )} | ||
| </ModalConsumer>, |
There was a problem hiding this comment.
Any reason we are changing the logic here?
There was a problem hiding this comment.
There was a bug in that implementation there due to which the button was not working properly, so have fixed that
SuZhou-Joe
reviewed
Aug 20, 2024
| @@ -14,6 +14,7 @@ import { | |||
| EuiOverlayMask, | |||
| EuiCodeBlock, | |||
| } from "@elastic/eui"; | |||
| import { size } from "lodash"; | |||
There was a problem hiding this comment.
Suggested change
| import { size } from "lodash"; |
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
tandonks
changed the title
Signed-off-by: Kshitij Tandon <[email protected]>
tandonks
changed the title
|
@tandonks closing this PR since you've opened a new one with required changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR achieves 3 things:
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.