Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate feel and look good guide changes for snapshots pages, datastreams, rollups and notification settings #1132

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Incorporate feel and look good guide changes for snapshots pages, datastreams, rollups and notification settings #1132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f143c69
Incorporate feel and look good guide changes for snapshots pages, dat…
Aug 20, 2024
484df4b
update snapshots of pages after feel and look good chanegs
Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions public/components/ContentPanel/ContentPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ const ContentPanel: React.SFC<ContentPanelProps> = ({
<EuiFlexItem>
{typeof title === "string" ? (
<EuiTitle size={titleSize}>
<h3>
<h1>
{title}
<span className="panel-header-count"> {itemCount > 0 ? `(${itemCount})` : null} </span>
</h3>
</h1>
</EuiTitle>
) : (
title
Expand Down
4 changes: 2 additions & 2 deletions public/components/ContentPanel/__snapshots__/ContentPanel.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ exports[`<ContentPanel /> spec renders the component 1`] = `
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--large"
>
Testing
Expand All @@ -22,7 +22,7 @@ exports[`<ContentPanel /> spec renders the component 1`] = `


</span>
</h3>
</h1>
</div>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
Expand Down
2 changes: 1 addition & 1 deletion public/components/DeleteModal/DeleteModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default function DeleteTemplateModal(props: DeleteModalProps) {
))}
</ul>
<EuiSpacer />
<EuiText color="subdued">
<EuiText color="subdued" size="s">
To confirm your action, type <b style={{ color: "#000" }}>delete</b>.
</EuiText>
<EuiFieldText
Expand Down
2 changes: 1 addition & 1 deletion public/components/DeleteModal/__snapshots__/DeleteModal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ HTMLCollection [
class="euiSpacer euiSpacer--l"
/>
<div
class="euiText euiText--medium"
class="euiText euiText--small"
>
<div
class="euiTextColor euiTextColor--subdued"
Expand Down
4 changes: 2 additions & 2 deletions public/components/IndexDetail/__snapshots__/IndexDetail.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ exports[`<IndexDetail /> spec renders the component 1`] = `
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Define index
Expand All @@ -22,7 +22,7 @@ exports[`<IndexDetail /> spec renders the component 1`] = `


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down
4 changes: 2 additions & 2 deletions public/containers/IndexDetail/__snapshots__/IndexDetail.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exports[`<IndexDetail /> spec render the component 1`] = `
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Source index details
Expand All @@ -23,7 +23,7 @@ exports[`<IndexDetail /> spec render the component 1`] = `


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down
8 changes: 4 additions & 4 deletions public/containers/IndexForm/__snapshots__/IndexForm.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exports[`<IndexForm /> spec render page 1`] = `
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Define index
Expand All @@ -23,7 +23,7 @@ exports[`<IndexForm /> spec render page 1`] = `


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down Expand Up @@ -195,7 +195,7 @@ exports[`<IndexForm /> spec render page 1`] = `
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Index settings
Expand All @@ -205,7 +205,7 @@ exports[`<IndexForm /> spec render page 1`] = `


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down
4 changes: 2 additions & 2 deletions ...gePolicy/components/ChangeManagedIndices/__snapshots__/ChangeManagedIndices.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ exports[`<ChangeManagedIndices /> spec renders the component 1`] = `
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Choose managed indices
Expand All @@ -22,7 +22,7 @@ exports[`<ChangeManagedIndices /> spec renders the component 1`] = `


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down
4 changes: 2 additions & 2 deletions public/pages/ChangePolicy/components/NewPolicy/__snapshots__/NewPolicy.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ exports[`<NewPolicy /> spec renders the component 1`] = `
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Choose new policy
Expand All @@ -22,7 +22,7 @@ exports[`<NewPolicy /> spec renders the component 1`] = `


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down
8 changes: 4 additions & 4 deletions public/pages/ChangePolicy/containers/ChangePolicy/__snapshots__/ChangePolicy.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ exports[`<ChangePolicy /> spec renders the component 1`] = `
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Choose managed indices
Expand All @@ -33,7 +33,7 @@ exports[`<ChangePolicy /> spec renders the component 1`] = `


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down Expand Up @@ -223,7 +223,7 @@ exports[`<ChangePolicy /> spec renders the component 1`] = `
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Choose new policy
Expand All @@ -233,7 +233,7 @@ exports[`<ChangePolicy /> spec renders the component 1`] = `


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down
8 changes: 4 additions & 4 deletions public/pages/Commons/BaseAggregationAndMetricSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const BaseMetricsColumns: Readonly<EuiTableFieldDataColumnType<MetricItem
export function sequenceTableComponents(selectedDimensionField, items, columns, pagination, sorting, onChange) {
if (selectedDimensionField.length == 0) {
return (
<EuiText>
<EuiText size="xs">
<dd>No fields added for aggregation</dd>
</EuiText>
);
Expand Down Expand Up @@ -120,12 +120,12 @@ export function additionalMetricsComponent(selectedMetrics) {
return (
<EuiFlexGroup gutterSize="xs">
<EuiFlexItem grow={false}>
<EuiText>
<EuiText size="s">
<h3>Additional metrics</h3>
</EuiText>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiText color="subdued" textAlign="left">
<EuiText color="subdued" textAlign="left" size="s">
<h3>{`(${selectedMetrics.length})`}</h3>
</EuiText>
</EuiFlexItem>
Expand All @@ -136,7 +136,7 @@ export function additionalMetricsComponent(selectedMetrics) {
export function sourceFieldComponents(selectedMetrics, items, columns, pagination, sorting, onChange) {
if (selectedMetrics.length == 0) {
return (
<EuiText>
<EuiText size="xs">
<dd>No fields added for metrics</dd>
</EuiText>
);
Expand Down
8 changes: 4 additions & 4 deletions .../containers/CreateComposableTemplate/__snapshots__/CreateComposableTemplate.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ exports[`<CreateComposableTemplate /> spec it goes to templates page when click
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Define component template
Expand All @@ -78,7 +78,7 @@ exports[`<CreateComposableTemplate /> spec it goes to templates page when click


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down Expand Up @@ -272,7 +272,7 @@ exports[`<CreateComposableTemplate /> spec it goes to templates page when click
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Index settings
Expand All @@ -282,7 +282,7 @@ exports[`<CreateComposableTemplate /> spec it goes to templates page when click


</span>
</h3>
</h1>
</div>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
Expand Down
8 changes: 4 additions & 4 deletions ...teComposableTemplate/containers/TemplateDetail/__snapshots__/TemplateDetail.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ exports[`<TemplateDetail /> spec render component 1`] = `
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Define component template
Expand All @@ -63,7 +63,7 @@ exports[`<TemplateDetail /> spec render component 1`] = `


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down Expand Up @@ -307,7 +307,7 @@ exports[`<TemplateDetail /> spec render component 1`] = `
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Index settings
Expand All @@ -317,7 +317,7 @@ exports[`<TemplateDetail /> spec render component 1`] = `


</span>
</h3>
</h1>
</div>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
Expand Down
4 changes: 2 additions & 2 deletions ...CreateDataStream/containers/CreateDataStream/__snapshots__/CreateDataStream.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ exports[`<CreateDataStream /> spec it goes to data streams page when click cance
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Define data stream
Expand All @@ -110,7 +110,7 @@ exports[`<CreateDataStream /> spec it goes to data streams page when click cance


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down
3 changes: 1 addition & 2 deletions public/pages/CreateDataStream/containers/DataStreamDetail/DataStreamDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,7 @@ const DataStreamDetail = (props: DataStreamDetailProps, ref: Ref<FieldInstance>)
<EuiText size="s" color="subdued">
A data stream is composed of multiple backing indexes. Search requests are routed to all the backing indexes, while indexing
requests <br></br>
are routed to the latest write index.
<ExternalLink href={coreServices.docLinks.links.opensearch.dataStreams} />
are routed to the latest write index. <ExternalLink href={coreServices.docLinks.links.opensearch.dataStreams} />
</EuiText>
),
},
Expand Down
4 changes: 2 additions & 2 deletions ...CreateDataStream/containers/DataStreamDetail/__snapshots__/DataStreamDetail.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ exports[`<DataStreamDetail /> spec render component 1`] = `
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Define data stream
Expand All @@ -107,7 +107,7 @@ exports[`<DataStreamDetail /> spec render component 1`] = `


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down
8 changes: 4 additions & 4 deletions .../CreateIndexTemplate/components/DefineTemplate/__snapshots__/DefineTemplate.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exports[`<ComposableTemplatesActions /> spec renders the component in edit mode
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Template settings
Expand All @@ -23,7 +23,7 @@ exports[`<ComposableTemplatesActions /> spec renders the component in edit mode


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down Expand Up @@ -408,7 +408,7 @@ exports[`<ComposableTemplatesActions /> spec renders the component in non-edit m
<div
class="euiFlexItem"
>
<h3
<h1
class="euiTitle euiTitle--small"
>
Template settings
Expand All @@ -418,7 +418,7 @@ exports[`<ComposableTemplatesActions /> spec renders the component in non-edit m


</span>
</h3>
</h1>
</div>
</div>
<hr
Expand Down
Loading
Loading