Update new header for notification settings page in ISM #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skumawat2025
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
CaptainDredge
approved these changes
Aug 19, 2024
skumawat2025
force-pushed
the
notification-setting-change
branch
2 times, most recently
from
5e68b32 to
73ca3af
Compare
added 2 commits
August 19, 2024 10:13
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025
force-pushed
the
notification-setting-change
branch
from
73ca3af to
192741b
Compare
SuZhou-Joe
approved these changes
Aug 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Update new header for notification settings page in ISM Signed-off-by: Sandeep Kumawat <[email protected]> * fix tests Signed-off-by: Sandeep Kumawat <[email protected]> --------- Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> (cherry picked from commit df7848c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Update new header for notification settings page in ISM * fix tests --------- (cherry picked from commit df7848c) Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sandeep Kumawat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update new header for notification settings page in ISM.
NOTE: Please merge this PR after this dependent PR is merged: #1121
OLD UI
NEW UI
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.