Making Look and Feel Changes in ISM pages #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2024 23:16
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
astute-decipher
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
- Coverage 63.43% 61.70% -1.73%
==========================================
Files 344 345 +1
Lines 11668 12384 +716
Branches 2260 2486 +226
==========================================
+ Hits 7402 7642 +240
- Misses 3689 4056 +367
- Partials 577 686 +109 ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
The changes look good to me but do we need to make such changes behind the toggle? cc @AMoo-Miki
yes @SuZhou-Joe , as we don’t want to change the existing UI. The button size small and search bars has to be compressed only in new UI. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Making some look good changes in ISM policy pages Signed-off-by: Shubh Sahu <[email protected]> * more loog good changes Signed-off-by: Shubh Sahu <[email protected]> --------- Signed-off-by: Shubh Sahu <[email protected]> Co-authored-by: Shubh Sahu <[email protected]> (cherry picked from commit 7086d36) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Making some look good changes in ISM policy pages * more loog good changes --------- (cherry picked from commit 7086d36) Signed-off-by: Shubh Sahu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shubh Sahu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is followup for PR. Making few look and feel good changes. For making buttons size small & bars compressed.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Few changes in Create Index State management pages :
OldUi :
NewUi :
OldUi:
NewUi:
