Use smaller and compressed varients of buttons and form components #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
AMoo-Miki
force-pushed
the
lnf-demo-2
branch
2 times, most recently
from
7596c81 to
333af07
Compare
1 task
|
There are some places that the Cypress test is consuming the class name to do assertion, and change the component is breaking the test cases. |
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
|
I have resolved conflicts. Please prioritize reviewing and merging this PR. |
| EuiAccordion, | ||
| EuiRadioGroup, | ||
| EuiCompressedRadioGroup, |
There was a problem hiding this comment.
EuiCompressedRadioGroup has been imported twice. Can we please remove this.
| @@ -12,7 +12,7 @@ import { | |||
| Criteria, | |||
| Direction, | |||
| EuiBasicTable, | |||
| EuiButton, | |||
| EuiSmallButton, | |||
There was a problem hiding this comment.
EuiSmallButton has been imported twice. Can we please remove this.
Signed-off-by: Miki <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1103 +/- ##
==========================================
- Coverage 61.61% 61.41% -0.21%
==========================================
Files 345 345
Lines 12449 12656 +207
Branches 2509 2556 +47
==========================================
+ Hits 7671 7773 +102
- Misses 4075 4148 +73
- Partials 703 735 +32 ☔ View full report in Codecov by Sentry. |
Signed-off-by: SuZhou-Joe <[email protected]>
|
Changed the Cypress test case a little bit to make it pass in this PR. |
SuZhou-Joe
approved these changes
Aug 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
…1103) * Use EuiSmallButton Signed-off-by: Miki <[email protected]> * Use EuiSmallButtonIcon Signed-off-by: Miki <[email protected]> * Use EuiSmallButtonEmpty Signed-off-by: Miki <[email protected]> * Use EuiCompressedFormRow Signed-off-by: Miki <[email protected]> * Use EuiCompressedField* Signed-off-by: Miki <[email protected]> * Use EuiCompressedSelect and EuiCompressedSuperSelect Signed-off-by: Miki <[email protected]> * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup Signed-off-by: Miki <[email protected]> * Use EuiCompressedRadio and EuiCompressedRadioGroup Signed-off-by: Miki <[email protected]> * Use EuiCompressedSwitch Signed-off-by: Miki <[email protected]> * Use EuiCompressedEuiTextArea Signed-off-by: Miki <[email protected]> * Use EuiCompressedComboBox Signed-off-by: Miki <[email protected]> * Use EuiSmallFilterButton Signed-off-by: Miki <[email protected]> * Use EuiCompressedSuperDatePicker Signed-off-by: Miki <[email protected]> * Update snapshots Signed-off-by: Miki <[email protected]> * Fix bad `useNewUX` applications Signed-off-by: Miki <[email protected]> * Fix tests Signed-off-by: Miki <[email protected]> * Update tests and snapshots post-conflict resolution Signed-off-by: Miki <[email protected]> * fix: e2e test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 7077166) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Aug 21, 2024
…1103) * Use EuiSmallButton Signed-off-by: Miki <[email protected]> * Use EuiSmallButtonIcon Signed-off-by: Miki <[email protected]> * Use EuiSmallButtonEmpty Signed-off-by: Miki <[email protected]> * Use EuiCompressedFormRow Signed-off-by: Miki <[email protected]> * Use EuiCompressedField* Signed-off-by: Miki <[email protected]> * Use EuiCompressedSelect and EuiCompressedSuperSelect Signed-off-by: Miki <[email protected]> * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup Signed-off-by: Miki <[email protected]> * Use EuiCompressedRadio and EuiCompressedRadioGroup Signed-off-by: Miki <[email protected]> * Use EuiCompressedSwitch Signed-off-by: Miki <[email protected]> * Use EuiCompressedEuiTextArea Signed-off-by: Miki <[email protected]> * Use EuiCompressedComboBox Signed-off-by: Miki <[email protected]> * Use EuiSmallFilterButton Signed-off-by: Miki <[email protected]> * Use EuiCompressedSuperDatePicker Signed-off-by: Miki <[email protected]> * Update snapshots Signed-off-by: Miki <[email protected]> * Fix bad `useNewUX` applications Signed-off-by: Miki <[email protected]> * Fix tests Signed-off-by: Miki <[email protected]> * Update tests and snapshots post-conflict resolution Signed-off-by: Miki <[email protected]> * fix: e2e test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 7077166) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Aug 21, 2024
…1103) (#1140) * Use EuiSmallButton * Use EuiSmallButtonIcon * Use EuiSmallButtonEmpty * Use EuiCompressedFormRow * Use EuiCompressedField* * Use EuiCompressedSelect and EuiCompressedSuperSelect * Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup * Use EuiCompressedRadio and EuiCompressedRadioGroup * Use EuiCompressedSwitch * Use EuiCompressedEuiTextArea * Use EuiCompressedComboBox * Use EuiSmallFilterButton * Use EuiCompressedSuperDatePicker * Update snapshots * Fix bad `useNewUX` applications * Fix tests * Update tests and snapshots post-conflict resolution * fix: e2e test --------- (cherry picked from commit 7077166) Signed-off-by: Miki <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace instances of
EuiButtonthat don't have an explicit sizing attribute toEuiSmallButton*.Replace instances of
Eui<form elements>that don't have density attributes toEuiCompressed<form elements>.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.