Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated charts to follow the OpenSearch Project's inclusive language standards #560

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Phenix66
Copy link

Description

This will bring the charts in line with https://opensearch.org/blog/Adopting-inclusive-language-across-OpenSearch/

Additionally it resolves the issue where a multi-replica cluster fails to perform initial discovery when you attempt to use the role from the inclusive language and deploy the chart with the following values

roles:
  - cluster_manager
  - ingest
  - data
  - remote_cluster_client

In this case, you will observe the following log message repeated a few times

[2024-07-16T02:47:56,461][WARN ][o.o.c.c.ClusterFormationFailureHelper] [opensearch-cluster-master-0] cluster-manager not discovered yet, this node has not previously joined a bootstrapped cluster, and [cluster.initial_cluster_manager_nodes] is empty on this node: have discovered [{opensearch-cluster-master-0}{4LevXxJKSjqPPDCHL3xQXA}{AC5gnzcwR5yR9CKGuan3Og}{10.244.1.8}{10.244.1.8:9300}{dimr}{shard_indexing_pressure_enabled=true}, {opensearch-cluster-master-1}{xw8pX8CcTBWNl2ylGCxp-w}{2XFteZTzRrOZ6ilsxJC6Ug}{10.244.3.7}{10.244.3.7:9300}{dimr}{shard_indexing_pressure_enabled=true}, {opensearch-cluster-master-2}{y_bTw1kcQWOhNyDAI2MZ7A}{tN-aAkHLTduCo6g7EsR2HQ}{10.244.2.7}{10.244.2.7:9300}{dimr}{shard_indexing_pressure_enabled=true}]; discovery will continue using [10.244.3.7:9300, 10.244.2.7:9300] from hosts providers and [{opensearch-cluster-master-0}{4LevXxJKSjqPPDCHL3xQXA}{AC5gnzcwR5yR9CKGuan3Og}{10.244.1.8}{10.244.1.8:9300}{dimr}{shard_indexing_pressure_enabled=true}] from last-known cluster state; node term 0, last-accepted version 0 in term 0

with this log message also repeating over and over

[2024-07-16T02:47:56,469][INFO ][o.o.s.c.ConfigurationRepository] [opensearch-cluster-master-0] Wait for cluster to be available ...

Issues Resolved

#276
#366

Check List

  • Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

  • Helm chart version bumped
  • Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Phenix66 Phenix66 force-pushed the bugfix/inclusive-language branch from 4ed75a7 to c00e4e5 Compare July 17, 2024 01:21
Copy link
Member

@TheAlgo TheAlgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Phenix66 Thanks for your contribution. Can you resolve conflicts?

@Phenix66
Copy link
Author

@Phenix66 Thanks for your contribution. Can you resolve conflicts?

Resolved

@Phenix66 Phenix66 requested a review from TheAlgo September 7, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

2 participants