added description for lifecycle parameter #482
Conversation
premkirank
requested review from
bbarani,
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
Signed-off-by: premkiran <[email protected]>
Signed-off-by: premkiran <[email protected]>
There was a problem hiding this comment.
@premkirank Thanks for your contribution. Changes looks good to me. Can you rebase with latest version of the chart. We released a new version yesterday so maybe you can build on top of that. Thanks
P:S There is a PR with similar changes raised 3 weeks ago so we need to wait on that PR. If that contributor can rebase we need to merge that change as that was raised first :)
Signed-off-by: Rishabh Singh <[email protected]>
|
@premkirank can you please take a look at this comment. Thanks |
@prudhvigodithi I had rebased my PR and requested a review again. Is there anything else that I have missed? |
|
Thanks, the CI tests fail can you please take care of it @premkirank ? |
|
@prudhvigodithi I am not able to understand why the tests are failing. Please help here. |
There was a problem hiding this comment.
@premkirank You have updated the appVersion to 2.12 and we don't have a version of OpenSearch yet. Can you revert this to 2.11. You only need to update chart version and not app version.
Signed-off-by: premkiran <[email protected]>
@TheAlgo @prudhvigodithi have reverted the app version |
|
@prudhvigodithi Please do have a look when free. Thanks |
|
Thanks @TheAlgo, @premkirank can you please backport this to 1.x branch as well? this is for the OpenSearch 1.x series. |
prudhvigodithi
added
the
backport 1.x
@prudhvigodithi Here is the backport PR - #491 |
Description
Added a
descriptionfor the lifecycle parameter in READMEIssues Resolved
Fixes #459
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.