-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow adding plugins and change defaultmode for opensearch dashboards #342
allow adding plugins and change defaultmode for opensearch dashboards #342
Conversation
… yaml file Signed-off-by: Lu Yu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BionIT Can you refactor the PR according to contribution guidelines mentioned in CONTRIBUTING.md
@TheAlgo Sure! Do we need to bump |
appversion keep 2.3.0, just bump version. |
Signed-off-by: Lu Yu <[email protected]>
Signed-off-by: Lu Yu <[email protected]>
Thanks @peterzhuamazon and @TheAlgo ! I have bumped version for osd chart, linter was complaining about version bump for os, but I only updated documentation for os chart, and per CONTRIBUTING.md: |
Yes this is not ideal but this is a backlog for this repo. Our linter is configured this way. @prudhvigodithi / @peterzhuamazon We need to fix this ASAP. In the meanwhile @BionIT can you bump minor version for OS chart as well so that linter is happy |
Signed-off-by: Lu Yu <[email protected]>
Sure, @TheAlgo! Thanks for clarifying! I have bumped version for os chart as well and the linter is happy now :). |
@@ -47,6 +47,9 @@ spec: | |||
- name: config | |||
configMap: | |||
name: {{ template "opensearch-dashboards.fullname" . }}-config | |||
{{- if .Values.opensearchDashboardsYml.defaultMode }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use some other intuitive name here. I don't mind directly adding defaultMode
as well. @prudhvigodithi @DandyDeveloper @peterzhuamazon Opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple configmaps, and I think being explicit would help if we introduce more custom configurations about defaultmode for those configmaps. Open to a better naming if we have any
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding @prudhvigodithi to take a look at this. |
@prudhvigodithi @DandyDeveloper Please take a look when free. Thanks |
Heya, what's the latest on getting this reviewed? I'd like to get this merged. |
set -e | ||
{{- range $plugin := .Values.plugins.installList }} | ||
./bin/opensearch-dashboards-plugin install {{ $plugin }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BionIT quick question, for OpenSearch we have a --batch
option to force install without a prompt, is there a same flag or scenario for opensearch-dashboards-plugin
, I dont see it in the document though https://opensearch.org/docs/latest/dashboards/install/plugins/, please test this and share your update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @prudhvigodithi, --batch is not supported by opensearch-dashboards-plugin(error: unknown option '--batch'
), I have been using this script to install plugins and never had prompts.
Hey @BionIT thanks for the PR and contribution, please check the following points.
@TheAlgo @DandyDeveloper @peterzhuamazon @bbarani @seraphjiang |
Signed-off-by: Lu Yu <[email protected]>
Signed-off-by: Lu Yu <[email protected]>
Per request, resolved conflicts. |
Signed-off-by: Lu Yu <[email protected]>
Pinging @DandyDeveloper @TheAlgo @prudhvigodithi again for the checks on @BionIT latest changes. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks for being patient on this.
@rishabh6788 please approve.
Thanks.
Trying to fix the issues with linting. |
Related to kind action need to update to 1.3.0. |
Hi @BionIT please have a follow-up backport PR to 1.x. |
Backport 1.x: #359 |
…opensearch-project#342) * allow adding plugins and change defaultmode for opensearch dashboards yaml file Signed-off-by: Lu Yu <[email protected]> * bump version and update changelog Signed-off-by: Lu Yu <[email protected]> * add new line Signed-off-by: Lu Yu <[email protected]> * bump version for os Signed-off-by: Lu Yu <[email protected]> * resolve conflict in changelog Signed-off-by: Lu Yu <[email protected]> * trigger build Signed-off-by: Lu Yu <[email protected]> Signed-off-by: Lu Yu <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Signed-off-by: prathaptce <[email protected]>
* Update appVersion for 2.4.0 release (#350) Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: prathaptce <[email protected]> * Add .whitesource configuration file (#353) Co-authored-by: mend-for-github.aaakk.us.kg[bot] <50673670+mend-for-github.aaakk.us.kg[bot]@users.noreply.github.com> Signed-off-by: prathaptce <[email protected]> * Resolve Kind Cluster not able to be built in PR checks (#356) Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: prathaptce <[email protected]> * Fix the kindest/node docker images versions (#357) * Resolve Kind Cluster not able to be built in PR checks Signed-off-by: Peter Zhu <[email protected]> * Fix the kindest/node versions on docker images Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: prathaptce <[email protected]> * Resolve Kind Cluster not able to be built in PR checks (#358) Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: prathaptce <[email protected]> * allow adding plugins and change defaultmode for opensearch dashboards (#342) * allow adding plugins and change defaultmode for opensearch dashboards yaml file Signed-off-by: Lu Yu <[email protected]> * bump version and update changelog Signed-off-by: Lu Yu <[email protected]> * add new line Signed-off-by: Lu Yu <[email protected]> * bump version for os Signed-off-by: Lu Yu <[email protected]> * resolve conflict in changelog Signed-off-by: Lu Yu <[email protected]> * trigger build Signed-off-by: Lu Yu <[email protected]> Signed-off-by: Lu Yu <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Signed-off-by: prathaptce <[email protected]> * Fix path in securityConfig section on OpenSearch (values.yaml) (#344) * fix securityConfig.path Signed-off-by: Ruslan Gainanov <[email protected]> * add link to issue Signed-off-by: Ruslan Gainanov <[email protected]> Signed-off-by: Ruslan Gainanov <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Signed-off-by: prathaptce <[email protected]> * Update appVersion to 2.4.1 (#363) * Update appVersion to 2.4.1 Signed-off-by: Sayali Gaikawad <[email protected]> * Update appVersion to 2.4.1 Signed-off-by: Sayali Gaikawad <[email protected]> * Fix changelog Signed-off-by: Sayali Gaikawad <[email protected]> * Fix changelog Signed-off-by: Sayali Gaikawad <[email protected]> * Fix version Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: prathaptce <[email protected]> * Fix version for OpenSearch Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: prathaptce <[email protected]> * Fix version for OpenSearch-Dasboards Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: prathaptce <[email protected]> * Add hostPort support for http- and transport-ports (#336) Signed-off-by: Christian Kuhn <[email protected]> Signed-off-by: prathaptce <[email protected]> * Updated MAINTAINERS.md to match recommended opensearch-project format. (#367) Signed-off-by: dblock <[email protected]> Signed-off-by: dblock <[email protected]> Signed-off-by: prathaptce <[email protected]> * Bump OS and OSD version to 2.5.0 (#373) Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: prathaptce <[email protected]> * Created untriaged issue workflow. (#382) Signed-off-by: dblock <[email protected]> Signed-off-by: prathaptce <[email protected]> * Bump OpenSearch and Dashboards to 2.6.0 (#393) Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: prathaptce <[email protected]> * Updating the CODEOWNERS file (#399) Signed-off-by: bbarani <[email protected]> Signed-off-by: prathaptce <[email protected]> * Add lifecycle support in opensearch container (#376) * Add lifecycle support in opensearch container Signed-off-by: josephteddick <[email protected]> * lifecycle support PR cleanup Signed-off-by: josephteddick <[email protected]> --------- Signed-off-by: josephteddick <[email protected]> Signed-off-by: prathaptce <[email protected]> * feat: Add user-defined labels option to ingress (#390) Signed-off-by: Jason Witkowski <[email protected]> Co-authored-by: Jason Witkowski <[email protected]> Signed-off-by: prathaptce <[email protected]> * Update deployment.yaml Signed-off-by: prathaptce <[email protected]> * Update values.yaml Signed-off-by: prathaptce <[email protected]> * Update values.yaml Signed-off-by: prathaptce <[email protected]> * Update statefulset.yaml Signed-off-by: prathaptce <[email protected]> * Updating chart version and changelog.md Signed-off-by: Prathap Mahalingam (Nokia) <[email protected]> Signed-off-by: prathaptce <[email protected]> * Add lifecycle support in opensearch container (#376) * Add lifecycle support in opensearch container Signed-off-by: josephteddick <[email protected]> * lifecycle support PR cleanup Signed-off-by: josephteddick <[email protected]> --------- Signed-off-by: josephteddick <[email protected]> Signed-off-by: prathaptce <[email protected]> * Add github-merit-badger.yml (#408) Signed-off-by: Prudhvi Godithi <[email protected]> Signed-off-by: prathaptce <[email protected]> * Service port for performance analyzer (#346) * Performance analyzer port mapping Signed-off-by: Philipp Hölscher <[email protected]> * Performance analyzer port on ci-values Signed-off-by: Philipp Hölscher <[email protected]> * Update changelog Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Philipp Hölscher <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Signed-off-by: prathaptce <[email protected]> * Incorporated the review comments Signed-off-by: prathaptce <[email protected]> * Update values.yaml Signed-off-by: prathaptce <[email protected]> * Incorporated the review comments Signed-off-by: prathaptce <[email protected]> * Correcting the merge conflicts Signed-off-by: prathaptce <[email protected]> * Updated the README.md for OpenSearch & Dashboard Signed-off-by: prathaptce <[email protected]> * Updated the changelog message Signed-off-by: prathaptce <[email protected]> * Updating the version number Signed-off-by: prathaptce <[email protected]> --------- Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: prathaptce <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Lu Yu <[email protected]> Signed-off-by: Ruslan Gainanov <[email protected]> Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: Christian Kuhn <[email protected]> Signed-off-by: dblock <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: bbarani <[email protected]> Signed-off-by: josephteddick <[email protected]> Signed-off-by: Jason Witkowski <[email protected]> Signed-off-by: Prathap Mahalingam (Nokia) <[email protected]> Signed-off-by: Prudhvi Godithi <[email protected]> Signed-off-by: Philipp Hölscher <[email protected]> Co-authored-by: Zelin Hao <[email protected]> Co-authored-by: mend-for-github.aaakk.us.kg[bot] <50673670+mend-for-github.aaakk.us.kg[bot]@users.noreply.github.com> Co-authored-by: Peter Zhu <[email protected]> Co-authored-by: Lu Yu <[email protected]> Co-authored-by: Ruslan Gainanov <[email protected]> Co-authored-by: Sayali Gaikawad <[email protected]> Co-authored-by: Sayali Gaikawad <[email protected]> Co-authored-by: Christian Kuhn <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Rishabh Singh <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Barani <[email protected]> Co-authored-by: Joseph Teddick <[email protected]> Co-authored-by: Jason Witkowski <[email protected]> Co-authored-by: Jason Witkowski <[email protected]> Co-authored-by: Prudhvi Godithi <[email protected]> Co-authored-by: Philipp Hölscher <[email protected]>
Signed-off-by: Lu Yu [email protected]
Description
Similar to #71 , the change would allow installing external plugins when container starts for opensearch dashboards.
In addition, this change allows to specify defaultMode for the opensearch_dashboards.yml file which is mounted as configmap
Changelog and Readme are updated.
Changes were tested using k8s cluster using the chart
Issues Resolved
#341
Check List
For any changes to files within Helm chart directories:
CHANGELOG.md
updated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.