Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flag to control the network policy creation #171

Merged
merged 4 commits into from
Dec 20, 2021

Conversation

rubemlrm
Copy link
Contributor

Description

This change was relative to a new flag that will validate the need to create a network policy. I had an use case where the user accounts can't create network policies.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Copy link
Member

Hi @rubemlrm could you create an issues related to this?

Also, due to 1.2.1 PR #164 is merged, you need to pull the latest changes, use 1.5.5 version number, and resolve conflicts.

If you can also remove the extra spaces you introduced in changelog, that will be great.

Thanks.

@rubemlrm
Copy link
Contributor Author

Hi @rubemlrm could you create an issues related to this?

Also, due to 1.2.1 PR #164 is merged, you need to pull the latest changes, use 1.5.5 version number, and resolve conflicts.

If you can also remove the extra spaces you introduced in changelog, that will be great.

Thanks.

Hi @peterzhuamazon, created the issue #176 for this PR. I will do the changes that you recommended.

Fixed merge conflicts on CHANGELOG.md

Signed-off-by: Rubem Mota <[email protected]>
@rubemlrm
Copy link
Contributor Author

@peterzhuamazon i think that now it's all fine. I've merged the main branch and bumped versions.

@peterzhuamazon
Copy link
Member

I think your IDE is adding extra spaces everywhere, can you take a look @rubemlrm and address my comments?
Thanks.

@rubemlrm
Copy link
Contributor Author

I think your IDE is adding extra spaces everywhere, can you take a look @rubemlrm and address my comments? Thanks.

Just updated the code, i had a question relative to the comment on the parameters list, it's to align the '|' before Enable with the upper line ? Or was something else?

thanks a lot for the help and feedback

@peterzhuamazon
Copy link
Member

Stays on 1.5.5.

@peterzhuamazon
Copy link
Member

I think your IDE is adding extra spaces everywhere, can you take a look @rubemlrm and address my comments? Thanks.

Just updated the code, i had a question relative to the comment on the parameters list, it's to align the '|' before Enable with the upper line ? Or was something else?

thanks a lot for the help and feedback

You good in the latest commit.
Thanks.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@TheAlgo
Copy link
Member

TheAlgo commented Dec 20, 2021

@DandyDeveloper Please have a look when free. Thanks

Copy link
Collaborator

@DandyDeveloper DandyDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, should have been conditional from the start. Thank you @rubemlrm

@TheAlgo
Copy link
Member

TheAlgo commented Dec 20, 2021

Thanks @rubemlrm for the PR. Merging it.

@TheAlgo TheAlgo merged commit e45a917 into opensearch-project:main Dec 20, 2021
TheAlgo pushed a commit to onelapahead/opensearch-helm-charts that referenced this pull request Dec 21, 2021
…#171)

* Added flag to control the network policy creation

Signed-off-by: Rubem Mota <[email protected]>

* Bump Opensearch chart to 1.5.5

Signed-off-by: Rubem Mota <[email protected]>

* Fixed wrong spaces and indentation for opensearch README.md and Changelog.md

Signed-off-by: Rubem Mota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement][Opensearch] Add possibility to enable/disable network policy creation
4 participants