-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flag to control the network policy creation #171
Conversation
Signed-off-by: Rubem Mota <[email protected]>
Hi @peterzhuamazon, created the issue #176 for this PR. I will do the changes that you recommended. |
Fixed merge conflicts on CHANGELOG.md Signed-off-by: Rubem Mota <[email protected]>
Signed-off-by: Rubem Mota <[email protected]>
@peterzhuamazon i think that now it's all fine. I've merged the main branch and bumped versions. |
I think your IDE is adding extra spaces everywhere, can you take a look @rubemlrm and address my comments? |
…elog.md Signed-off-by: Rubem Mota <[email protected]>
Just updated the code, i had a question relative to the comment on the parameters list, it's to align the '|' before Enable with the upper line ? Or was something else? thanks a lot for the help and feedback |
Stays on 1.5.5. |
You good in the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
@DandyDeveloper Please have a look when free. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change, should have been conditional from the start. Thank you @rubemlrm
Thanks @rubemlrm for the PR. Merging it. |
…#171) * Added flag to control the network policy creation Signed-off-by: Rubem Mota <[email protected]> * Bump Opensearch chart to 1.5.5 Signed-off-by: Rubem Mota <[email protected]> * Fixed wrong spaces and indentation for opensearch README.md and Changelog.md Signed-off-by: Rubem Mota <[email protected]>
Description
This change was relative to a new flag that will validate the need to create a network policy. I had an use case where the user accounts can't create network policies.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.