Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm opensearch version #163

Conversation

derek-diaz
Copy link
Contributor

@derek-diaz derek-diaz commented Dec 9, 2021

Description

Update appVersion to 1.2.0

Issues Resolved

#151

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@TheAlgo
Copy link
Member

TheAlgo commented Dec 9, 2021

Hi @derek-diaz

Thanks for making the PR. Can you bump the version and add CHANGELOG for the PR.
Follow the PR #149 to get an idea on what needs to be done. Also please sign off your commit

@derek-diaz
Copy link
Contributor Author

derek-diaz commented Dec 9, 2021

@TheAlgo

Would this considered to be a Major, Minor or Patch release?

@TheAlgo
Copy link
Member

TheAlgo commented Dec 9, 2021

@TheAlgo

Would this considered to be a Major, Minor or Patch release?

Patch release

Derek Diaz added 4 commits December 9, 2021 14:33
Signed-off-by: Derek Diaz <[email protected]>
Signed-off-by: Derek Diaz <[email protected]>
Signed-off-by: Derek Diaz <[email protected]>
Signed-off-by: Derek Diaz <[email protected]>
@derek-diaz
Copy link
Contributor Author

@TheAlgo Alright I think everything should be good now. Do let me know if I missed anything!

@peterzhuamazon
Copy link
Member

Hi @derek-diaz strange that DCO does not pass can you rebase and push as one commit again?
Thanks.

@derek-diaz derek-diaz closed this Dec 9, 2021
@derek-diaz derek-diaz deleted the update-helm-opensearch-version branch December 9, 2021 21:45
@derek-diaz
Copy link
Contributor Author

New Pull Request: #164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement][OpenSearch/OpenSearch Dashboards] Make 1.2 as default image for opensearch helm charts
3 participants