Fix depricated roles #116
Closed
Fix depricated roles #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add option to disable initContainer chown update Signed-off-by: Aaron Layfield <[email protected]> * True default, not false. Signed-off-by: Aaron Layfield <[email protected]> * Remove trailing spaces Signed-off-by: Aaron Layfield <[email protected]> * Updating CHANGELOG and README Signed-off-by: Aaron Layfield <[email protected]> Signed-off-by: Sebor <[email protected]>
Signed-off-by: TheAlgo <[email protected]> Signed-off-by: Your Name <[email protected]> Signed-off-by: Sebor <[email protected]>
Signed-off-by: TheAlgo <[email protected]> Signed-off-by: Sebor <[email protected]>
Signed-off-by: Your Name <[email protected]> Signed-off-by: Sebor <[email protected]>
Signed-off-by: Your Name <[email protected]> Signed-off-by: Sebor <[email protected]>
Signed-off-by: Your Name <[email protected]> Signed-off-by: Sebor <[email protected]>
Signed-off-by: Sebor <[email protected]> Signed-off-by: Your Name <[email protected]> Signed-off-by: Sebor <[email protected]>
…charts into fix-depricated-roles Signed-off-by: Your Name <[email protected]> Signed-off-by: Sebor <[email protected]>
Signed-off-by: Alan Mangashev <[email protected]> Signed-off-by: Your Name <[email protected]> Signed-off-by: Sebor <[email protected]>
|
Hi @TheAlgo, @peterzhuamazon, @smlx ! |
|
Hi @Sebor thanks for the PR could you please create an issue and link to this PR? Also, seems like you need to sign DCO check, and bump your chart version. Thanks. |
Signed-off-by: Sebor <[email protected]>
|
Hi @peterzhuamazon! |
Signed-off-by: Sebor <[email protected]>
There was a problem hiding this comment.
I'll double check this one but looks good. One thing @Sebor looks like your IDE or something has instead a CRLF on all the keys: {} making your branch look significantly more verbose.
Can you undo those changes?
|
Hi @peterzhuamazon, @DandyDeveloper, @TheAlgo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework deprecated node roles definition.
Now in
values.yamlroles are described as a list and there are no any deprecation warnings in logs.Related issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.