Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement][opensearch-dashboards] topologySpreadConstraints for dashboards #505

Closed
cpockrandt opened this issue Dec 8, 2023 · 4 comments
Closed

[Enhancement][opensearch-dashboards] topologySpreadConstraints for dashboards #505

cpockrandt opened this issue Dec 8, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@cpockrandt
Copy link
Contributor

cpockrandt commented Dec 8, 2023 •
edited
Loading

I was wondering whether it would be beneficial to add topologySpreadConstraints to the opensearch-dashboards Helm charts, similarly to the opensearch Helm chart (#222):

helm-charts/charts/opensearch/templates/statefulset.yaml

Lines 144 to 147 in 5bb0531

{{- if .Values.topologySpreadConstraints }}
topologySpreadConstraints:
{{- toYaml .Values.topologySpreadConstraints | nindent 8 }}
{{- end }}

E.g., to distribute the pods across multiple availability zones.
@cpockrandt cpockrandt added enhancement New feature or request untriaged Issues that have not yet been triaged labels Dec 8, 2023
@kinoute
Copy link
Contributor

kinoute commented Dec 14, 2023

Interested by this as well. I was about to create a pull request for that.

kinoute added a commit to kinoute/helm-charts that referenced this issue Dec 15, 2023
@kinoute
Add topology spread constraints in dashboards (opensearch-project#505)
006969c
kinoute added a commit to kinoute/helm-charts that referenced this issue Dec 15, 2023
@kinoute
Add topology spread constraints in dashboards (opensearch-project#505)
542b8fa
@kinoute kinoute mentioned this issue Dec 15, 2023
Merged
kinoute added a commit to kinoute/helm-charts that referenced this issue Dec 15, 2023
@kinoute
Add topology spread constraints in dashboards (opensearch-project#505)
4c02ea3 
Signed-off-by: Yan Defretin <[email protected]>
kinoute added a commit to kinoute/helm-charts that referenced this issue Dec 15, 2023
@kinoute
Add topology spread constraints in dashboards (opensearch-project#505)
c6766c1 
Signed-off-by: Yann Defretin <[email protected]>
@cpockrandt
Copy link
Contributor Author

I was just about to start a PR and saw that you already opened one! Thanks @kinoute!

@prudhvigodithi prudhvigodithi removed the untriaged Issues that have not yet been triaged label Dec 20, 2023
@prudhvigodithi
Copy link
Member

[Untraige]
Thanks @cpockrandt for raising the issue and thanks @kinoute for the contribution, I will take a look at the PR.

prudhvigodithi pushed a commit that referenced this issue Dec 21, 2023
@kinoute
Add topology spread constraints in dashboards (#505) (#509)
90beaed 
Signed-off-by: Yann Defretin <[email protected]>
@cpockrandt
Copy link
Contributor Author

I'm closing this issue, since it was already merged three months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kinoute @cpockrandt @prudhvigodithi